From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v8 7/7] mm,page_alloc: Drop unnecessary checks from pfn_range_valid_contig
Date: Thu, 15 Apr 2021 12:35:44 +0200 [thread overview]
Message-ID: <20210415103544.6791-8-osalvador@suse.de> (raw)
In-Reply-To: <20210415103544.6791-1-osalvador@suse.de>
pfn_range_valid_contig() bails out when it finds an in-use page or a
hugetlb page, among other things.
We can drop the in-use page check since __alloc_contig_pages can migrate
away those pages, and the hugetlb page check can go too since
isolate_migratepages_range is now capable of dealing with hugetlb pages.
Either way, those checks are racy so let the end function handle it
when the time comes.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Suggested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/page_alloc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b5a94de3cdde..c5338e912ace 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8901,12 +8901,6 @@ static bool pfn_range_valid_contig(struct zone *z, unsigned long start_pfn,
if (PageReserved(page))
return false;
-
- if (page_count(page) > 0)
- return false;
-
- if (PageHuge(page))
- return false;
}
return true;
}
--
2.16.3
next prev parent reply other threads:[~2021-04-15 10:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:35 [PATCH v8 0/7] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-04-15 10:35 ` [PATCH v8 1/7] mm,page_alloc: Bail out earlier on -ENOMEM in alloc_contig_migrate_range Oscar Salvador
2021-04-15 10:35 ` [PATCH v8 2/7] mm,compaction: Let isolate_migratepages_{range,block} return error codes Oscar Salvador
2021-04-15 12:42 ` David Hildenbrand
2021-04-15 10:35 ` [PATCH v8 3/7] mm,hugetlb: Drop clearing of flag from prep_new_huge_page Oscar Salvador
2021-04-15 11:41 ` Michal Hocko
2021-04-15 12:41 ` David Hildenbrand
2021-04-15 18:50 ` Mike Kravetz
2021-04-15 10:35 ` [PATCH v8 4/7] mm,hugetlb: Split prep_new_huge_page functionality Oscar Salvador
2021-04-15 12:42 ` David Hildenbrand
2021-04-15 10:35 ` [PATCH v8 5/7] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-04-15 12:45 ` David Hildenbrand
2021-04-15 18:54 ` Mike Kravetz
2021-04-15 10:35 ` [PATCH v8 6/7] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-04-15 10:35 ` Oscar Salvador [this message]
2021-04-15 11:42 ` [PATCH v8 7/7] mm,page_alloc: Drop unnecessary checks from pfn_range_valid_contig Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415103544.6791-8-osalvador@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).