From: Luiz Sampaio <sampaio.ime@gmail.com>
To: zbr@ioremap.net
Cc: corbet@lwn.net, rikard.falkeborn@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Luiz Sampaio <sampaio.ime@gmail.com>
Subject: [PATCH v7 1/6] w1: ds2438: fixed a coding style issue
Date: Fri, 16 Apr 2021 19:17:34 -0300 [thread overview]
Message-ID: <20210416221739.501090-2-sampaio.ime@gmail.com> (raw)
In-Reply-To: <20210416221739.501090-1-sampaio.ime@gmail.com>
There is an if statement and, if the function goes into it, it returns. So,
the next else is not required.
Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
---
drivers/w1/slaves/w1_ds2438.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c
index 5cfb0ae23e91..148921fb9702 100644
--- a/drivers/w1/slaves/w1_ds2438.c
+++ b/drivers/w1/slaves/w1_ds2438.c
@@ -154,11 +154,11 @@ static int w1_ds2438_change_config_bit(struct w1_slave *sl, u8 mask, u8 value)
if ((status & mask) == value)
return 0; /* already set as requested */
- else {
- /* changing bit */
- status ^= mask;
- perform_write = 1;
- }
+
+ /* changing bit */
+ status ^= mask;
+ perform_write = 1;
+
break;
}
--
2.30.1
next prev parent reply other threads:[~2021-04-16 22:16 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 1:24 [PATCH v2 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 1/9] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 2/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 3/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 4/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 5/9] " Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 6/9] " Luiz Sampaio
2021-04-03 3:16 ` kernel test robot
2021-04-03 3:29 ` kernel test robot
2021-04-03 1:24 ` [PATCH v2 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-03 1:24 ` [PATCH v2 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-03 4:45 ` [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 1/9] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 2/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 3/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 4/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 5/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 6/9] " Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-03 4:48 ` [PATCH v3 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 1/9] w1: ds2438: fixed a coding style issue after return Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read Luiz Sampaio
2021-04-05 10:52 ` Greg KH
2021-04-05 10:50 ` [PATCH v4 3/9] w1: ds2438: fixed a coding style issue in temperature_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 4/9] w1: ds2438: fixed a coding style issue in vad_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 5/9] w1: ds2438: fixed a coding style issue in vdd_read Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style Luiz Sampaio
2021-04-05 10:53 ` Greg KH
2021-04-05 12:47 ` Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 7/9] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 8/9] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-05 10:50 ` [PATCH v4 9/9] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 11:04 ` Greg KH
2021-04-05 12:44 ` Luiz Sampaio
2021-04-05 12:50 ` Greg KH
2021-04-05 10:53 ` [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements Greg KH
2021-04-05 12:45 ` Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 " Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 4:39 ` Joe Perches
2021-04-09 14:40 ` Joe Perches
2021-04-16 22:26 ` Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 9:44 ` kernel test robot
2021-04-09 10:43 ` kernel test robot
2021-04-10 8:38 ` Greg KH
2021-04-09 3:15 ` [PATCH v6 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-16 22:17 ` Luiz Sampaio [this message]
2021-04-16 22:17 ` [PATCH v7 2/6] w1: ds2438: fixed if brackets coding style issue Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-17 5:25 ` kernel test robot
2021-05-14 11:47 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Greg KH
2021-05-19 22:30 ` [PATCH v8 " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-05 10:32 ` [PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416221739.501090-2-sampaio.ime@gmail.com \
--to=sampaio.ime@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).