drm/msm: always parse interconnects
diff mbox series

Message ID 20210417161912.62811-1-caleb@connolly.tech
State New
Headers show
Series
  • drm/msm: always parse interconnects
Related show

Commit Message

Caleb Connolly April 17, 2021, 4:21 p.m. UTC
The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
platforms. As SDM845 now has interconnects hooked up we should always
try and parse them.

Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Rob Clark April 17, 2021, 5:52 p.m. UTC | #1
On Sat, Apr 17, 2021 at 9:21 AM Caleb Connolly <caleb@connolly.tech> wrote:
>
> The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
> platforms. As SDM845 now has interconnects hooked up we should always
> try and parse them.
>
> Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>

I believe this series in msm-next already solves this

https://patchwork.freedesktop.org/series/88644/

BR,
-R

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 85f2c3564c96..fb061e666faa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
>                 DPU_DEBUG("REG_DMA is not defined");
>         }
>
> -       if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
> -               dpu_kms_parse_data_bus_icc_path(dpu_kms);
> +       dpu_kms_parse_data_bus_icc_path(dpu_kms);
>
>         pm_runtime_get_sync(&dpu_kms->pdev->dev);
>
> --
> 2.30.2
>
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 85f2c3564c96..fb061e666faa 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -933,8 +933,7 @@  static int dpu_kms_hw_init(struct msm_kms *kms)
 		DPU_DEBUG("REG_DMA is not defined");
 	}
 
-	if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
-		dpu_kms_parse_data_bus_icc_path(dpu_kms);
+	dpu_kms_parse_data_bus_icc_path(dpu_kms);
 
 	pm_runtime_get_sync(&dpu_kms->pdev->dev);