From: Martin Kaiser <martin@kaiser.cx>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 2/4] staging: rtl8188eu: remove constant variable and dead code
Date: Sat, 17 Apr 2021 20:00:35 +0200 [thread overview]
Message-ID: <20210417180037.17806-2-martin@kaiser.cx> (raw)
In-Reply-To: <20210417180037.17806-1-martin@kaiser.cx>
g_wifi_on is always true. Remove the variable and the code that would
be run only if g_wifi_on was false.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/rtl8188eu/os_dep/rtw_android.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/rtw_android.c b/drivers/staging/rtl8188eu/os_dep/rtw_android.c
index f5763a9d70c5..2d21767bc1a3 100644
--- a/drivers/staging/rtl8188eu/os_dep/rtw_android.c
+++ b/drivers/staging/rtl8188eu/os_dep/rtw_android.c
@@ -53,15 +53,9 @@ struct android_wifi_priv_cmd {
};
/**
- * Local (static) functions and variables
+ * Local (static) functions
*/
-/* Initialize g_wifi_on to 1 so dhd_bus_start will be called for the first
- * time (only) in dhd_open, subsequential wifi on will be handled by
- * wl_android_wifi_on
- */
-static int g_wifi_on = true;
-
int rtw_android_cmdstr_to_num(char *cmdstr)
{
int cmd_num;
@@ -154,12 +148,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd)
case ANDROID_WIFI_CMD_SETFWPATH:
goto response;
}
- if (!g_wifi_on) {
- DBG_88E("%s: Ignore private cmd \"%s\" - iface %s is down\n",
- __func__, command, ifr->ifr_name);
- ret = 0;
- goto free;
- }
switch (cmd_num) {
case ANDROID_WIFI_CMD_STOP:
break;
@@ -244,7 +232,6 @@ int rtw_android_priv_cmd(struct net_device *net, struct ifreq *ifr, int cmd)
} else {
ret = bytes_written;
}
-free:
kfree(command);
return ret;
}
--
2.20.1
next prev parent reply other threads:[~2021-04-17 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 18:00 [PATCH 1/4] staging: rtl8188eu: change bLeisurePs' type to bool Martin Kaiser
2021-04-17 18:00 ` Martin Kaiser [this message]
2021-04-17 19:57 ` [PATCH 2/4] staging: rtl8188eu: remove constant variable and dead code kernel test robot
2021-04-17 18:00 ` [PATCH 3/4] staging: rtl8188eu: cmdThread is a task_struct Martin Kaiser
2021-04-17 18:00 ` [PATCH 4/4] staging: rtl8188eu: remove unused function parameters Martin Kaiser
2021-04-19 20:11 ` [PATCH v2 1/4] staging: rtl8188eu: change bLeisurePs' type to bool Martin Kaiser
2021-04-19 20:11 ` [PATCH v2 2/4] staging: rtl8188eu: remove constant variable and dead code Martin Kaiser
2021-04-19 20:11 ` [PATCH v2 3/4] staging: rtl8188eu: cmdThread is a task_struct Martin Kaiser
2021-04-19 20:11 ` [PATCH v2 4/4] staging: rtl8188eu: remove unused function parameters Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417180037.17806-2-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).