From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
hello@bryanbrattlof.com, hdegoede@redhat.com,
saurav.girepunje@google.com, john.oldman@polehill.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: [PATCH] staging: rtl8723bs: os_dep: remove multiple return
Date: Sun, 18 Apr 2021 23:02:33 +0530 [thread overview]
Message-ID: <20210418173233.GA59153@user> (raw)
on sdio_intf.c rtw_sdio_suspend call we have multiple
return which can replace by goto exit. As in all the places
return value is 0.
Signed-off-by: Saurav Girepunje <saurav.girepunje@google.com>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index a9a9631dd23c..3e566cf97f6e 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -445,14 +445,17 @@ static int rtw_sdio_suspend(struct device *dev)
struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
if (padapter->bDriverStopped)
- return 0;
+ goto exit;
if (pwrpriv->bInSuspend) {
pdbgpriv->dbg_suspend_error_cnt++;
- return 0;
+ goto exit;
}
- return rtw_suspend_common(padapter);
+ rtw_suspend_common(padapter);
+exit:
+
+ return 0;
}
static int rtw_resume_process(struct adapter *padapter)
--
2.25.1
next reply other threads:[~2021-04-18 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 17:32 Saurav Girepunje [this message]
2021-04-20 11:03 ` [PATCH] staging: rtl8723bs: os_dep: remove multiple return Dan Carpenter
2021-04-20 11:06 ` Dan Carpenter
2021-04-27 19:45 ` SAURAV GIREPUNJE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418173233.GA59153@user \
--to=saurav.girepunje@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hello@bryanbrattlof.com \
--cc=john.oldman@polehill.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=saurav.girepunje@google.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).