platform/chrome: cros_ec_typec: Track port role
diff mbox series

Message ID 20210420171008.3829549-1-pmalani@chromium.org
State Accepted
Commit 670160fea22c587b384d56698bbb661fa4801534
Headers show
Series
  • platform/chrome: cros_ec_typec: Track port role
Related show

Commit Message

Prashant Malani April 20, 2021, 5:10 p.m. UTC
Stash the currently reported port role in the port struct and add a
check for that too while determining whether to re-configure on-board
Type C switches (this deals with cases like role swaps where the mux
flags don't change, but the port role does).

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Suggested-by: Nikunj A. Dadhania <nikunj.dadhania@intel.com>
Tested-by: Deepti Deshatty <deepti.deshatty@intel.com>
---
 drivers/platform/chrome/cros_ec_typec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Enric Balletbo i Serra April 23, 2021, 6:57 a.m. UTC | #1
On Tue, 20 Apr 2021 10:10:09 -0700, Prashant Malani wrote:
> Stash the currently reported port role in the port struct and add a
> check for that too while determining whether to re-configure on-board
> Type C switches (this deals with cases like role swaps where the mux
> flags don't change, but the port role does).

Applied, thanks!

[1/1] platform/chrome: cros_ec_typec: Track port role
      commit: 670160fea22c587b384d56698bbb661fa4801534

Best regards,

Patch
diff mbox series

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d3df1717a5fd..1a06b8c80f80 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -58,6 +58,7 @@  struct cros_typec_port {
 	/* Variables keeping track of switch state. */
 	struct typec_mux_state state;
 	uint8_t mux_flags;
+	uint8_t role;
 
 	/* Port alt modes. */
 	struct typec_altmode p_altmode[CROS_EC_ALTMODE_MAX];
@@ -995,10 +996,12 @@  static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
 	}
 
 	/* No change needs to be made, let's exit early. */
-	if (typec->ports[port_num]->mux_flags == mux_resp.flags)
+	if (typec->ports[port_num]->mux_flags == mux_resp.flags &&
+	    typec->ports[port_num]->role == resp.role)
 		return 0;
 
 	typec->ports[port_num]->mux_flags = mux_resp.flags;
+	typec->ports[port_num]->role = resp.role;
 	ret = cros_typec_configure_mux(typec, port_num, mux_resp.flags, &resp);
 	if (ret)
 		dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);