platform/chrome: cros_ec_typec: Add DP mode check
diff mbox series

Message ID 20210421042108.2002-1-pmalani@chromium.org
State In Next
Commit c5bb32f57bf3a30ed03be51f7be0840325ba8b4a
Headers show
Series
  • platform/chrome: cros_ec_typec: Add DP mode check
Related show

Commit Message

Prashant Malani April 21, 2021, 4:21 a.m. UTC
There are certain transitional situations where the dp_mode field in the
PD_CONTROL response might not be populated with the right DP pin
assignment value yet. Add a check for that to avoid sending an invalid
value to the Type C mode switch.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
 drivers/platform/chrome/cros_ec_typec.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Enric Balletbo i Serra April 23, 2021, 6:57 a.m. UTC | #1
On Tue, 20 Apr 2021 21:21:09 -0700, Prashant Malani wrote:
> There are certain transitional situations where the dp_mode field in the
> PD_CONTROL response might not be populated with the right DP pin
> assignment value yet. Add a check for that to avoid sending an invalid
> value to the Type C mode switch.

Applied, thanks!

[1/1] platform/chrome: cros_ec_typec: Add DP mode check
      commit: c5bb32f57bf3a30ed03be51f7be0840325ba8b4a

Best regards,

Patch
diff mbox series

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index d3df1717a5fd..69646262fa9d 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -486,6 +486,11 @@  static int cros_typec_enable_dp(struct cros_typec_data *typec,
 		return -ENOTSUPP;
 	}
 
+	if (!pd_ctrl->dp_mode) {
+		dev_err(typec->dev, "No valid DP mode provided.\n");
+		return -EINVAL;
+	}
+
 	/* Status VDO. */
 	dp_data.status = DP_STATUS_ENABLED;
 	if (port->mux_flags & USB_PD_MUX_HPD_IRQ)