[039/190] Revert "iommu: Fix reference count leak in iommu_group_alloc."
diff mbox series

Message ID 20210421130105.1226686-40-gregkh@linuxfoundation.org
State New, archived
Headers show
Series
  • Revertion of all of the umn.edu commits
Related show

Commit Message

Greg KH April 21, 2021, 12:58 p.m. UTC
This reverts commit 7cc31613734c4870ae32f5265d576ef296621343.

Commits from @umn.edu addresses have been found to be submitted in "bad
faith" to try to test the kernel community's ability to review "known
malicious" changes.  The result of these submissions can be found in a
paper published at the 42nd IEEE Symposium on Security and Privacy
entitled, "Open Source Insecurity: Stealthily Introducing
Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
of Minnesota) and Kangjie Lu (University of Minnesota).

Because of this, all submissions from this group must be reverted from
the kernel tree and will need to be re-reviewed again to determine if
they actually are a valid fix.  Until that work is complete, remove this
change to ensure that no problems are being introduced into the
codebase.

Cc: Qiushi Wu <wu000273@umn.edu>
Cc: https
Cc: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/iommu/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joerg Roedel April 22, 2021, 7:52 a.m. UTC | #1
Hi Greg,

On Wed, Apr 21, 2021 at 02:58:34PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 7cc31613734c4870ae32f5265d576ef296621343.

I reviewed this fix again and it looks still valid and correct to me.
There is no need for a revert.

Thanks,

	Joerg
Greg KH April 22, 2021, 8:12 a.m. UTC | #2
On Thu, Apr 22, 2021 at 09:52:28AM +0200, Joerg Roedel wrote:
> Hi Greg,
> 
> On Wed, Apr 21, 2021 at 02:58:34PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 7cc31613734c4870ae32f5265d576ef296621343.
> 
> I reviewed this fix again and it looks still valid and correct to me.
> There is no need for a revert.

Wonderful, thanks for the review, I appreciate it!

greg k-h

Patch
diff mbox series

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index d0b0a15dba84..cd22cd0e6517 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -596,7 +596,7 @@  struct iommu_group *iommu_group_alloc(void)
 				   NULL, "%d", group->id);
 	if (ret) {
 		ida_simple_remove(&iommu_group_ida, group->id);
-		kobject_put(&group->kobj);
+		kfree(group);
 		return ERR_PTR(ret);
 	}