From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: joe@perches.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 03/50] staging: rtl8723bs: add two functions to improve register dump in core/rtw_debug.c
Date: Sat, 24 Apr 2021 11:01:46 +0200 [thread overview]
Message-ID: <0f3300e6b07f811c0d3fc9c6dd46e5270dfb7a54.1619254603.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1619254603.git.fabioaiuto83@gmail.com>
Beautify register dump by adding two functions printing
four register values per line. This is necessary after
old macro replacement with netdev_dbg(), the former
wrapped a raw printk, the latter
prints lots of driver information overhead per line
for each call. So avoid this noisy behaviour by dumping
four values on each line.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 63 ++++++++++++----------
1 file changed, 35 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
index a43fa38cae62..0e13a226e9be 100644
--- a/drivers/staging/rtl8723bs/core/rtw_debug.c
+++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
@@ -14,41 +14,54 @@ u32 GlobalDebugLevel = _drv_err_;
#include <rtw_version.h>
+static void dump_4_regs(struct adapter *adapter, int offset)
+{
+ u32 reg[4];
+ int i;
+
+ for (i = 0; i < 4; i++)
+ reg[i] = rtw_read32(adapter, offset + i);
+
+ netdev_dbg(adapter->pnetdev, "0x%03x 0x%08x 0x%08x 0x%08x 0x%08x\n",
+ i, reg[0], reg[1], reg[2], reg[3]);
+}
+
void mac_reg_dump(void *sel, struct adapter *adapter)
{
- int i, j = 1;
+ int i;
netdev_dbg(adapter->pnetdev, "======= MAC REG =======\n");
- for (i = 0x0; i < 0x800; i += 4) {
- if (j%4 == 1)
- netdev_dbg(adapter->pnetdev, "0x%03x", i);
- netdev_dbg(adapter->pnetdev, " 0x%08x ",
- rtw_read32(adapter, i));
- if ((j++)%4 == 0)
- netdev_dbg(adapter->pnetdev, "\n");
- }
+ for (i = 0x0; i < 0x800; i += 4)
+ dump_4_regs(adapter, i);
}
void bb_reg_dump(void *sel, struct adapter *adapter)
{
- int i, j = 1;
+ int i;
netdev_dbg(adapter->pnetdev, "======= BB REG =======\n");
- for (i = 0x800; i < 0x1000 ; i += 4) {
- if (j%4 == 1)
- netdev_dbg(adapter->pnetdev, "0x%03x", i);
- netdev_dbg(adapter->pnetdev, " 0x%08x ",
- rtw_read32(adapter, i));
- if ((j++)%4 == 0)
- netdev_dbg(adapter->pnetdev, "\n");
- }
+
+ for (i = 0x800; i < 0x1000 ; i += 4)
+ dump_4_regs(adapter, i);
+}
+
+static void dump_4_rf_regs(struct adapter *adapter, int path, int offset)
+{
+ u8 reg[4];
+ int i;
+
+ for (i = 0; i < 4; i++)
+ reg[i] = rtw_hal_read_rfreg(adapter, path, offset + i,
+ 0xffffffff);
+
+ netdev_dbg(adapter->pnetdev, "0x%02x 0x%08x 0x%08x 0x%08x 0x%08x\n",
+ i, reg[0], reg[1], reg[2], reg[3]);
}
void rf_reg_dump(void *sel, struct adapter *adapter)
{
- int i, j = 1, path;
- u32 value;
+ int i, path;
u8 rf_type = 0;
u8 path_nums = 0;
@@ -62,13 +75,7 @@ void rf_reg_dump(void *sel, struct adapter *adapter)
for (path = 0; path < path_nums; path++) {
netdev_dbg(adapter->pnetdev, "RF_Path(%x)\n", path);
- for (i = 0; i < 0x100; i++) {
- value = rtw_hal_read_rfreg(adapter, path, i, 0xffffffff);
- if (j%4 == 1)
- netdev_dbg(adapter->pnetdev, "0x%02x ", i);
- netdev_dbg(adapter->pnetdev, " 0x%08x ", value);
- if ((j++)%4 == 0)
- netdev_dbg(adapter->pnetdev, "\n");
- }
+ for (i = 0; i < 0x100; i++)
+ dump_4_rf_regs(adapter, path, i);
}
}
--
2.20.1
next prev parent reply other threads:[~2021-04-24 9:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 9:01 [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 01/50] staging: rtl8723bs: remove unused log function Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 02/50] staging: rtl8723bs: replace DBG_871X_SEL log macro with netdev_dbg() Fabio Aiuto
2021-04-24 9:01 ` Fabio Aiuto [this message]
2021-04-24 9:01 ` [PATCH v2 04/50] staging: rtl8723bs: remove DBG_871X_SEL macro declaration Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 05/50] staging: rtl8723bs: remove unused _DBG_871X_LEVEL macro Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 06/50] staging: rtl8723bs: remove unused mac_reg_dump() function argument Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 07/50] staging: rtl8723bs: remove unused bb_reg_dump() " Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 08/50] staging: rtl8723bs: remove unused rf_reg_dump() " Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 09/50] staging: rtl8723bs: remove unused RTW_DBGDUMP macro definition Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 10/50] staging: rtl8723bs: remove all defs related to _dbgdump macro Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 11/50] staging: rtl8723bs: remove unused debug variables declarations and initialization Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 12/50] staging: rtl8723bs: remove unneeded header file include Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 13/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 14/50] staging: rtl8723bs: remove debug macros related to core/rtw_xmit.c tracing Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 15/50] staging: rtl8723bs: remove debug macros related to os_dep/xmit_linux.c tracing Fabio Aiuto
2021-04-24 9:01 ` [PATCH v2 16/50] staging: rtl8723bs: remove debug macros related to core/rtw_recv.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 17/50] staging: rtl8723bs: remove debug macros related to os_dep/recv_linux.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 18/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 19/50] staging: rtl8723bs: remove debug macros related to os_dep/mlme_linux.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 20/50] staging: rtl8723bs: move static array definition from header to .c file Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 21/50] staging: rtl8723bs: remove debug macros related to core/rtw_mlme_ext.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 22/50] staging: rtl8723bs: remove debug macros related to core/rtw_sta_mgt.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 23/50] staging: rtl8723bs: remove debug macros related to core/rtw_cmd.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 24/50] staging: rtl8723bs: remove obsolete debug macro definitions Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 25/50] staging: rtl8723bs: remove debug macros related to core/rtw_io.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 26/50] staging: rtl8723bs: remove obsolete _IO_OSDEP_C_ debug macro definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 27/50] staging: rtl8723bs: remove debug macros related to os_dep/os_intfs.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 28/50] staging: rtl8723bs: remove debug macros related to core/rtw_security.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 29/50] staging: rtl8723bs: remove debug macros related to core/rtw_eeprom.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 30/50] staging: rtl8723bs: remove debug macros related to hal/hal_intf.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 31/50] staging: rtl8723bs: remove debug macros related to hal/sdio_halinit.c tracing Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 32/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 33/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_SET_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 34/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_QUERY_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 35/50] staging: rtl8723bs: remove unused debug macros tied to _RTL871X_PWRCTRL_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 36/50] staging: rtl8723bs: remove unused macros tied to core/rtw_pwrctrl.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 37/50] staging: rtl8723bs: remove unused macros tied to os_dep/sdio_intf.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 38/50] staging: rtl8723bs: remove unused debug macros tied to _HCI_OPS_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 39/50] staging: rtl8723bs: remove unused debug macros tied to hal/sdio_ops.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 40/50] staging: rtl8723bs: remove unused debug macros tied to os_dep/osdep_service.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 41/50] staging: rtl8723bs: remove unused _module_mp_ def Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 42/50] staging: rtl8723bs: remove unused macros tied to _HCI_OPS_OS_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 43/50] staging: rtl8723bs: remove unused macros tied to _RTL871X_IOCTL_LINUX_C definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 44/50] staging: rtl8723bs: remove unused macros tied to _RTL8712_CMD_C_ definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 45/50] staging: rtl8723bs: remove commented out macro definition Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 46/50] staging: rtl8723bs: remove unused debug macro definitions Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 47/50] staging: rtl8723bs: remove unused macros tied to core/rtw_efuse.c debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 48/50] staging: rtl8723bs: remove unsed debug macros tied to no particular code debug Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 49/50] staging: rtl8723bs: remove last unused debug macros Fabio Aiuto
2021-04-24 9:02 ` [PATCH v2 50/50] staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver name Fabio Aiuto
2021-04-27 11:04 ` Greg KH
2021-04-27 12:41 ` Fabio Aiuto
2021-04-27 14:03 ` Greg KH
2021-04-27 11:06 ` [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h Greg KH
2021-04-27 12:42 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3300e6b07f811c0d3fc9c6dd46e5270dfb7a54.1619254603.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).