From: Wang Qing <wangqing@vivo.com>
To: Jonathan Corbet <corbet@lwn.net>, Wang Qing <wangqing@vivo.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Joe Perches <joe@perches.com>, Stephen Kitt <steve@sk2.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Randy Dunlap <rdunlap@infradead.org>,
"Guilherme G. Piccoli" <gpiccoli@canonical.com>,
Qais Yousef <qais.yousef@arm.com>, Petr Mladek <pmladek@suse.com>,
Santosh Sivaraj <santosh@fossix.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V2,RESEND 1/4] kernel: watchdog: Modify the explanation related to watchdog thread
Date: Thu, 29 Apr 2021 17:04:25 +0800 [thread overview]
Message-ID: <1619687073-24686-2-git-send-email-wangqing@vivo.com> (raw)
The watchdog thread has been replaced by cpu_stop_work, modify the
explanation related.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
kernel/watchdog.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 7110906..d7fb4fb
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -92,7 +92,7 @@ __setup("nmi_watchdog=", hardlockup_panic_setup);
* own hardlockup detector.
*
* watchdog_nmi_enable/disable can be implemented to start and stop when
- * softlockup watchdog threads start and stop. The arch must select the
+ * softlockup watchdog start and stop. The arch must select the
* SOFTLOCKUP_DETECTOR Kconfig.
*/
int __weak watchdog_nmi_enable(unsigned int cpu)
@@ -322,7 +322,7 @@ static DEFINE_PER_CPU(struct completion, softlockup_completion);
static DEFINE_PER_CPU(struct cpu_stop_work, softlockup_stop_work);
/*
- * The watchdog thread function - touches the timestamp.
+ * The watchdog feed function - touches the timestamp.
*
* It only runs once every sample_period seconds (4 seconds by
* default) to reset the softlockup timestamp. If this gets delayed
@@ -551,11 +551,7 @@ static void lockup_detector_reconfigure(void)
}
/*
- * Create the watchdog thread infrastructure and configure the detector(s).
- *
- * The threads are not unparked as watchdog_allowed_mask is empty. When
- * the threads are successfully initialized, take the proper locks and
- * unpark the threads in the watchdog_cpumask if the watchdog is enabled.
+ * Create the watchdog infrastructure and configure the detector(s).
*/
static __init void lockup_detector_setup(void)
{
@@ -621,7 +617,7 @@ void lockup_detector_soft_poweroff(void)
#ifdef CONFIG_SYSCTL
-/* Propagate any changes to the watchdog threads */
+/* Propagate any changes to the watchdog infrastructure */
static void proc_watchdog_update(void)
{
/* Remove impossible cpus to keep sysctl output clean. */
--
2.7.4
next reply other threads:[~2021-04-29 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 9:04 Wang Qing [this message]
2021-04-29 9:04 ` [PATCH V2,RESEND 2/4] doc: watchdog: Delete the explanation about "watchdog/%u" Wang Qing
2021-04-29 9:04 ` [PATCH V2,RESEND 3/4] doc: watchdog: Modify the explanation related to watchdog thread Wang Qing
2021-04-29 9:04 ` [PATCH V2,RESEND 4/4] doc: watchdog: Modify the doc related to "watchdog/%u" Wang Qing
2021-04-29 9:29 ` [PATCH V2,RESEND 1/4] kernel: watchdog: Modify the explanation related to watchdog thread Petr Mladek
2021-05-09 23:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619687073-24686-2-git-send-email-wangqing@vivo.com \
--to=wangqing@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gpiccoli@canonical.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=pmladek@suse.com \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=santosh@fossix.org \
--cc=steve@sk2.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).