From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 18/43] staging: rtl8723bs: remove commented out RT_ASSERT occurrences
Date: Fri, 30 Apr 2021 09:43:36 +0200 [thread overview]
Message-ID: <008f036ac799cecf2878d76fbfe28e10a2587ce6.1619768150.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1619768150.git.fabioaiuto83@gmail.com>
remove commented out obsoete RT_ASSERT macro occurences.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 2 --
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 -
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 -----
3 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 3e671cba6b94..c0689a4b7cb1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1794,8 +1794,6 @@ static int recv_indicatepkts_in_order(struct adapter *padapter, struct recv_reor
/* pTS->RxIndicateState = RXTS_INDICATE_PROCESSING; */
/* Indicate packets */
- /* RT_ASSERT((index<=REORDER_WIN_SIZE), ("RxReorderIndicatePacket(): Rx Reorder buffer full!!\n")); */
-
/* indicate this recv_frame */
/* DbgPrint("recv_indicatepkts_in_order, indicate_seq =%d, seq_num =%d\n", precvpriv->indicate_seq, pattrib->seq_num); */
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 082448557b53..4e21d98f7414 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -122,7 +122,6 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
u8 *bufferPtr = buffer;
pageNums = size / MAX_DLFW_PAGE_SIZE;
- /* RT_ASSERT((pageNums <= 4), ("Page numbers should not greater then 4\n")); */
remainSize = size % MAX_DLFW_PAGE_SIZE;
for (page = 0; page < pageNums; page++) {
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index fa285003b427..fd060cf7bc57 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -226,7 +226,6 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
value = QUEUE_NORMAL;
break;
default:
- /* RT_ASSERT(false, ("Shall not reach here!\n")); */
break;
}
@@ -260,7 +259,6 @@ static void _InitNormalChipTwoOutEpPriority(struct adapter *Adapter)
valueLow = QUEUE_NORMAL;
break;
default:
- /* RT_ASSERT(false, ("Shall not reach here!\n")); */
break;
}
@@ -325,7 +323,6 @@ static void _InitQueuePriority(struct adapter *Adapter)
_InitNormalChipThreeOutEpPriority(Adapter);
break;
default:
- /* RT_ASSERT(false, ("Shall not reach here!\n")); */
break;
}
@@ -516,7 +513,6 @@ static void _InitOperationMode(struct adapter *padapter)
regBwOpMode = BW_OPMODE_20MHZ;
break;
case WIRELESS_MODE_A:
-/* RT_ASSERT(false, ("Error wireless a mode\n")); */
break;
case WIRELESS_MODE_G:
regBwOpMode = BW_OPMODE_20MHZ;
@@ -530,7 +526,6 @@ static void _InitOperationMode(struct adapter *padapter)
regBwOpMode = BW_OPMODE_20MHZ;
break;
case WIRELESS_MODE_N_5G:
-/* RT_ASSERT(false, ("Error wireless mode")); */
regBwOpMode = BW_OPMODE_5G;
break;
--
2.20.1
next prev parent reply other threads:[~2021-04-30 7:45 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 7:43 [PATCH 00/43] staging: rtl8723bs: clean up driver from private debug facilities Fabio Aiuto
2021-04-30 7:43 ` [PATCH 01/43] staging: rtl8723bs: remove ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 02/43] staging: rlt8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion Fabio Aiuto
2021-04-30 14:31 ` Bryan Brattlof
2021-04-30 14:50 ` Fabio Aiuto
2021-04-30 15:02 ` Bryan Brattlof
2021-04-30 15:08 ` Fabio Aiuto
2021-04-30 7:43 ` [PATCH 03/43] staging: rtl8723bs: remove empty functions Fabio Aiuto
2021-04-30 7:43 ` [PATCH 04/43] staging: rtl8723bs: remove empty .c source file Fabio Aiuto
2021-04-30 12:51 ` kernel test robot
2021-04-30 7:43 ` [PATCH 05/43] staging: rtl8723bs: remove undefined function prototypes Fabio Aiuto
2021-04-30 7:43 ` [PATCH 06/43] staging: rtl8723bs: remove empty header file Fabio Aiuto
2021-04-30 7:43 ` [PATCH 07/43] staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 08/43] staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 09/43] staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg() Fabio Aiuto
2021-04-30 7:43 ` [PATCH 10/43] staging: rtl8723bs: remove unused ODM_RT_ASSERT macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 11/43] staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 12/43] staging: rtl8723bs: remove unused ODM_dbg_trace macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 13/43] staging: rtl8723bs: remove unused ODM_dbg_enter Fabio Aiuto
2021-04-30 7:43 ` [PATCH 14/43] staging: rtl8723bs: remove unused ODM_dbg_exit macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 15/43] staging: rtl8723bs: remove empty ifdef block Fabio Aiuto
2021-04-30 7:43 ` [PATCH 16/43] staging: rtl8723bs: remove unused ASSERT macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 17/43] staging: rtl8723bs: remove empty #ifndef block Fabio Aiuto
2021-04-30 7:43 ` Fabio Aiuto [this message]
2021-04-30 7:43 ` [PATCH 19/43] staging: rtl8723bs: remove unused RT_PRINTK macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 20/43] staging: rtl8723bs: remove BTC_PRINT logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 21/43] staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT removal Fabio Aiuto
2021-04-30 7:43 ` [PATCH 22/43] staging: rtl8723bs: remove braces around single statement in if block Fabio Aiuto
2021-04-30 7:43 ` [PATCH 23/43] staging: rtl8723bs: remove commented out BTC_PRINT logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 24/43] staging: rtl8723bs: remove BTC_PRINT macro definitions Fabio Aiuto
2021-04-30 7:43 ` [PATCH 25/43] staging: rtl8723bs: remove BTC_PRINT_ADDR " Fabio Aiuto
2021-04-30 7:43 ` [PATCH 26/43] staging: rtl8723bs: remove BTC_PRINT_DATA definitions Fabio Aiuto
2021-04-30 7:43 ` [PATCH 27/43] staging: rtl8723bs: remove BTC_PRINT_F macro definition Fabio Aiuto
2021-04-30 7:43 ` [PATCH 28/43] staging: rtl8723bs: remove empty #ifdef block Fabio Aiuto
2021-04-30 7:43 ` [PATCH 29/43] staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function Fabio Aiuto
2021-04-30 7:43 ` [PATCH 30/43] staging: rtl8723bs: remove hal_btcoex_GetDBG() function Fabio Aiuto
2021-04-30 7:43 ` [PATCH 31/43] staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function Fabio Aiuto
2021-04-30 7:43 ` [PATCH 32/43] staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations Fabio Aiuto
2021-04-30 7:43 ` [PATCH 33/43] staging: rtl8723bs: remove unused enum Fabio Aiuto
2021-04-30 7:43 ` [PATCH 34/43] staging: rtl8723bs: remove obsolete debug macros Fabio Aiuto
2021-04-30 7:43 ` [PATCH 35/43] staging: rtl8723bs: remove commented out DbgPrint logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 36/43] staging: rtl8723bs: remove unused DbgPrint macro Fabio Aiuto
2021-04-30 7:43 ` [PATCH 37/43] staging: rtl8723bs: remove commented out *RT_DISP logs Fabio Aiuto
2021-04-30 7:43 ` [PATCH 38/43] staging: rtl8723bs: remove RT_DISP macro definition Fabio Aiuto
2021-04-30 7:43 ` [PATCH 39/43] staging: rtl8723bs: remove ODM_InitDebugSetting() function Fabio Aiuto
2021-04-30 7:43 ` [PATCH 40/43] staging: rtl8723bs: remove empty file Fabio Aiuto
2021-04-30 14:54 ` kernel test robot
2021-04-30 7:43 ` [PATCH 41/43] staging: rtl8723bs: remove member in dm_odm_t struct Fabio Aiuto
2021-04-30 7:44 ` [PATCH 42/43] staging: rtl8723bs: remove DebugLevel " Fabio Aiuto
2021-04-30 7:44 ` [PATCH 43/43] staging: rtl8723bs: remove odm_debug.h header file Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=008f036ac799cecf2878d76fbfe28e10a2587ce6.1619768150.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).