[v3,16/43] staging: rtl8723bs: remove unused ASSERT macro
diff mbox series

Message ID f13bc57cc3a821c40443dddc38258b87962774a7.1619794331.git.fabioaiuto83@gmail.com
State In Next
Commit ae5351da40fb14d0a0c955595c3ac5711e33963d
Headers show
Series
  • staging: rtl8723bs: clean up driver from private debug facilities
Related show

Commit Message

Fabio Aiuto April 30, 2021, 2:56 p.m. UTC
remove unused do nothing ASSERT macro definition.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm_debug.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Dan Carpenter May 3, 2021, 7:31 a.m. UTC | #1
On Fri, Apr 30, 2021 at 04:56:38PM +0200, Fabio Aiuto wrote:
> remove unused do nothing ASSERT macro definition.
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_debug.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h
> index 8ae9948fb0c6..78b9b4548dcb 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_debug.h
> +++ b/drivers/staging/rtl8723bs/hal/odm_debug.h
> @@ -92,7 +92,6 @@
>  	#define RT_DISP(dbgtype, dbgflag, printstr)
>  
>  #ifndef ASSERT
> -	#define ASSERT(expr)
>  #endif

Presumably you're going to delete the #ifndef/endif in the next patch
but it should have been done in one step here.  (No need to resend.  For
future reference only).

regards,
dan carpenter
Fabio Aiuto May 3, 2021, 7:43 a.m. UTC | #2
On Mon, May 03, 2021 at 10:31:32AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:38PM +0200, Fabio Aiuto wrote:
> > remove unused do nothing ASSERT macro definition.
> > 
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/odm_debug.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > index 8ae9948fb0c6..78b9b4548dcb 100644
> > --- a/drivers/staging/rtl8723bs/hal/odm_debug.h
> > +++ b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > @@ -92,7 +92,6 @@
> >  	#define RT_DISP(dbgtype, dbgflag, printstr)
> >  
> >  #ifndef ASSERT
> > -	#define ASSERT(expr)
> >  #endif
> 
> Presumably you're going to delete the #ifndef/endif in the next patch
> but it should have been done in one step here.  (No need to resend.  For
> future reference only).
> 
> regards,
> dan carpenter
> 

ok, thank you,

fabio

Patch
diff mbox series

diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h
index 8ae9948fb0c6..78b9b4548dcb 100644
--- a/drivers/staging/rtl8723bs/hal/odm_debug.h
+++ b/drivers/staging/rtl8723bs/hal/odm_debug.h
@@ -92,7 +92,6 @@ 
 	#define RT_DISP(dbgtype, dbgflag, printstr)
 
 #ifndef ASSERT
-	#define ASSERT(expr)
 #endif
 
 void ODM_InitDebugSetting(struct dm_odm_t *pDM_Odm);