From: Khaled ROMDHANI <khaledromdhani216@gmail.com>
To: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: Khaled ROMDHANI <khaledromdhani216@gmail.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH-V3] fs/btrfs: Fix uninitialized variable
Date: Sat, 1 May 2021 02:11:36 +0100 [thread overview]
Message-ID: <20210501011136.29240-1-khaledromdhani216@gmail.com> (raw)
The variable 'zone' is uninitialized which
introduce some build warning when introduced
within the switch.
Fix that by changing the passed condition:
Catch explicitly any invalid 'mirror' value
as an assertion failure.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
---
V3: catch explicitly invalid mirror value
V2: force assertion failure by zeroing the zone variable
V1: initialize the zone variable
---
fs/btrfs/zoned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 432509f4b3ac..8250ab3f0868 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -144,7 +144,7 @@ static inline u32 sb_zone_number(int shift, int mirror)
case 1: zone = 1ULL << (BTRFS_SB_LOG_FIRST_SHIFT - shift); break;
case 2: zone = 1ULL << (BTRFS_SB_LOG_SECOND_SHIFT - shift); break;
default:
- ASSERT(zone);
+ ASSERT((u32)mirror < 3);
break;
}
base-commit: c05b2a58c9ed11bd753f1e64695bd89da715fbaa
--
2.17.1
next reply other threads:[~2021-05-01 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 1:11 Khaled ROMDHANI [this message]
2021-05-01 4:51 ` [PATCH-V3] fs/btrfs: Fix uninitialized variable kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210501011136.29240-1-khaledromdhani216@gmail.com \
--to=khaledromdhani216@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).