[v3,2/2] dt-bindings: mediatek: Add optional mediatek,gce-events property
diff mbox series

Message ID 20210504054612.3585017-2-hsinyi@chromium.org
State New, archived
Headers show
Series
  • [v3,1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex
Related show

Commit Message

Hsin-Yi Wang May 4, 2021, 5:46 a.m. UTC
This property is used by gce clients.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
---
 .../devicetree/bindings/mailbox/mtk-gce.txt       | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Rob Herring May 6, 2021, 8:31 p.m. UTC | #1
On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
> This property is used by gce clients.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> ---
>  .../devicetree/bindings/mailbox/mtk-gce.txt       | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Matthias Brugger May 12, 2021, 3:55 p.m. UTC | #2
Hi Jassi,

On 06/05/2021 22:31, Rob Herring wrote:
> On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
>> This property is used by gce clients.
>>
>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>> ---
>> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
>> ---
>>  .../devicetree/bindings/mailbox/mtk-gce.txt       | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

Will you take this through your branch, or do you prefer me taking it through mine?

Regards,
Matthias
Jassi Brar May 14, 2021, 3:24 a.m. UTC | #3
On Wed, 12 May 2021 at 10:55, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
> Hi Jassi,
>
> On 06/05/2021 22:31, Rob Herring wrote:
> > On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
> >> This property is used by gce clients.
> >>
> >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> >> ---
> >> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> >> ---
> >>  .../devicetree/bindings/mailbox/mtk-gce.txt       | 15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >>
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> >
>
> Will you take this through your branch, or do you prefer me taking it through mine?
>
I see I was not CC'ed on the patch. So I can't.

-j

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index 7771ecaac586..2ef7ff67cb2b 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -35,6 +35,10 @@  Optional properties for a client device:
   start_offset: the start offset of register address that GCE can access.
   size: the total size of register address that GCE can access.
 
+Optional properties for a client mutex node:
+- mediatek,gce-events: GCE events used by clients. The event numbers are
+  defined in 'dt-bindings/gce/<chip>-gce.h'.
+
 Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h',
 'dt-binding/gce/mt8183-gce.h' or 'dt-bindings/gce/mt6779-gce.h'. Such as
 sub-system ids, thread priority, event ids.
@@ -62,3 +66,14 @@  Example for a client device:
 					  <&gce SUBSYS_1401XXXX 0x2000 0x100>;
 		...
 	};
+
+Example for a client mutex node:
+	mutex: mutex@14020000 {
+		compatible = "mediatek,mt8173-disp-mutex";
+		reg = <0 0x14020000 0 0x1000>;
+		interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
+		power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
+		clocks = <&mmsys CLK_MM_MUTEX_32K>;
+		mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
+				      <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
+	};