iio: adc: mxs-lradc-adc: use iio_device_id() helper
diff mbox series

Message ID 20210504075304.148516-1-aardelean@deviqon.com
State New, archived
Headers show
Series
  • iio: adc: mxs-lradc-adc: use iio_device_id() helper
Related show

Commit Message

Alexandru Ardelean May 4, 2021, 7:53 a.m. UTC
The @id field was moved in commit e58bb7a74dca ("iio: core: move @id from
struct iio_dev to struct iio_dev_opaque"), however this driver was omitted
by accident, because the name of the IIO device is 'iio'.

This was caught by the lkp bot.

Fixes: e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
 drivers/iio/adc/mxs-lradc-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron May 8, 2021, 3:21 p.m. UTC | #1
On Tue,  4 May 2021 10:53:04 +0300
Alexandru Ardelean <aardelean@deviqon.com> wrote:

> The @id field was moved in commit e58bb7a74dca ("iio: core: move @id from
> struct iio_dev to struct iio_dev_opaque"), however this driver was omitted
> by accident, because the name of the IIO device is 'iio'.
> 
> This was caught by the lkp bot.
> 
> Fixes: e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>

Thanks.  I applied this as a fixup as that branch hadn't yet gone out as non
rebasing and I don't want to break bisection.

Also chased down how I'd missed this on in my test .config.  

Jonathan

> ---
>  drivers/iio/adc/mxs-lradc-adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
> index 30e29f44ebd2..1d99170d3328 100644
> --- a/drivers/iio/adc/mxs-lradc-adc.c
> +++ b/drivers/iio/adc/mxs-lradc-adc.c
> @@ -455,7 +455,7 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
>  	struct mxs_lradc_adc *adc = iio_priv(iio);
>  
>  	trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
> -				      iio->id);
> +				      iio_device_id(iio));
>  	if (!trig)
>  		return -ENOMEM;
>

Patch
diff mbox series

diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
index 30e29f44ebd2..1d99170d3328 100644
--- a/drivers/iio/adc/mxs-lradc-adc.c
+++ b/drivers/iio/adc/mxs-lradc-adc.c
@@ -455,7 +455,7 @@  static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
 	struct mxs_lradc_adc *adc = iio_priv(iio);
 
 	trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
-				      iio->id);
+				      iio_device_id(iio));
 	if (!trig)
 		return -ENOMEM;