media: i2c: ov2659: Fix an error message
diff mbox series

Message ID 1ed22753cd773e68e56c78eca01713d781097ffb.1620244953.git.christophe.jaillet@wanadoo.fr
State New, archived
Headers show
Series
  • media: i2c: ov2659: Fix an error message
Related show

Commit Message

Christophe JAILLET May 5, 2021, 8:03 p.m. UTC
'ret' is known to be 0 here and printing -ENODEV wouldn't be really
helpful.
So, print something that may be helpful instead.

Fixes: c4c0283ab3cd ("[media] media: i2c: add support for omnivision's ov2659 sensor")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/media/i2c/ov2659.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christophe JAILLET May 5, 2021, 8:11 p.m. UTC | #1
Le 05/05/2021 à 22:03, Christophe JAILLET a écrit :
> 'ret' is known to be 0 here and printing -ENODEV wouldn't be really
> helpful.
> So, print something that may be helpful instead.
> 
> Fixes: c4c0283ab3cd ("[media] media: i2c: add support for omnivision's ov2659 sensor")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/media/i2c/ov2659.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index 42f64175a6df..96bda172b334 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1368,8 +1368,8 @@ static int ov2659_detect(struct v4l2_subdev *sd)
>   		id = OV265X_ID(pid, ver);
>   		if (id != OV2659_ID) {
>   			dev_err(&client->dev,
> -				"Sensor detection failed (%04X, %d)\n",
> -				id, ret);
> +				"Sensor detection failed (id=%04X, pid=%X, ver=%X)\n",
> +				id, (int)pid, (int)ver);
>   			ret = -ENODEV;
>   		} else {
>   			dev_info(&client->dev, "Found OV%04X sensor\n", id);
> 

NACK.

I should have looked at OV265X_ID before sending the patch.

I'll send a v2 that just removes 'ret'.

CJ

Patch
diff mbox series

diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index 42f64175a6df..96bda172b334 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1368,8 +1368,8 @@  static int ov2659_detect(struct v4l2_subdev *sd)
 		id = OV265X_ID(pid, ver);
 		if (id != OV2659_ID) {
 			dev_err(&client->dev,
-				"Sensor detection failed (%04X, %d)\n",
-				id, ret);
+				"Sensor detection failed (id=%04X, pid=%X, ver=%X)\n",
+				id, (int)pid, (int)ver);
 			ret = -ENODEV;
 		} else {
 			dev_info(&client->dev, "Found OV%04X sensor\n", id);