linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH v5 04/30] media: i2c: dw9807-vcm: use pm_runtime_resume_and_get()
Date: Thu,  6 May 2021 17:23:00 +0200	[thread overview]
Message-ID: <351da21914f18f849f4898f948731b08dc1a3693.1620314098.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1620314098.git.mchehab+huawei@kernel.org>

Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/i2c/dw9807-vcm.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/media/i2c/dw9807-vcm.c b/drivers/media/i2c/dw9807-vcm.c
index 438a44b76da8..95e06f13bc9e 100644
--- a/drivers/media/i2c/dw9807-vcm.c
+++ b/drivers/media/i2c/dw9807-vcm.c
@@ -130,15 +130,7 @@ static const struct v4l2_ctrl_ops dw9807_vcm_ctrl_ops = {
 
 static int dw9807_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
 {
-	int rval;
-
-	rval = pm_runtime_get_sync(sd->dev);
-	if (rval < 0) {
-		pm_runtime_put_noidle(sd->dev);
-		return rval;
-	}
-
-	return 0;
+	return pm_runtime_resume_and_get(sd->dev);
 }
 
 static int dw9807_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
-- 
2.30.2


  parent reply	other threads:[~2021-05-06 15:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 15:22 [PATCH v5 00/30] media: i2c: use pm_runtime_resume_and_get() were possible Mauro Carvalho Chehab
2021-05-06 15:22 ` [PATCH v5 01/30] media: i2c: ak7375: use pm_runtime_resume_and_get() Mauro Carvalho Chehab
2021-05-06 15:22 ` [PATCH v5 02/30] media: i2c: dw9714: " Mauro Carvalho Chehab
2021-05-06 15:22 ` [PATCH v5 03/30] media: i2c: dw9768: " Mauro Carvalho Chehab
2021-05-06 15:23 ` Mauro Carvalho Chehab [this message]
2021-05-06 15:23 ` [PATCH v5 05/30] media: i2c: hi556: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 06/30] media: i2c: imx214: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 07/30] media: i2c: imx219: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 08/30] media: i2c: imx258: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 09/30] media: i2c: imx274: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 10/30] media: i2c: imx290: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 11/30] media: i2c: imx319: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 12/30] media: i2c: imx355: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 13/30] media: i2c: mt9m001: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 14/30] media: i2c: ov02a10: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 15/30] media: i2c: ov13858: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 16/30] media: i2c: ov2659: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 17/30] media: i2c: ov2685: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 18/30] media: i2c: ov2740: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 19/30] media: i2c: ov5647: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 20/30] media: i2c: ov5648: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 21/30] media: i2c: ov5670: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 22/30] media: i2c: ov5675: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 23/30] media: i2c: ov5695: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 24/30] media: i2c: ov7740: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 25/30] media: i2c: ov8856: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 26/30] media: i2c: ov8865: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 27/30] media: i2c: ov9734: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 28/30] media: i2c: tvp5150: " Mauro Carvalho Chehab
2021-05-06 15:23 ` [PATCH v5 29/30] media: i2c: video-i2c: " Mauro Carvalho Chehab
2021-05-07 21:26   ` Matt Ranostay
2021-05-06 15:23 ` [PATCH v5 30/30] media: i2c: ccs-core: " Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=351da21914f18f849f4898f948731b08dc1a3693.1620314098.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mauro.chehab@huawei.com \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).