From: Marco Elver <elver@google.com>
To: elver@google.com
Cc: linux-kernel@vger.kernel.org, apw@canonical.com, joe@perches.com,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
"Eric W . Biederman" <ebiederm@xmission.com>
Subject: [PATCH v3] checkpatch: warn about direct use of send_sig_info and force_sig_info
Date: Fri, 7 May 2021 15:16:58 +0200 [thread overview]
Message-ID: <20210507131658.3754171-1-elver@google.com> (raw)
Setting up siginfo and using send_sig_info() and force_sig_info()
directly is discouraged. Instead, new code wanting to generate signals
should use the appropriate helper specific to the signal.
Eric mentioned that he'd like to make these static at some point, but
until that can happen, let's try to avoid introducing new users of them.
Link: https://lkml.kernel.org/r/m17dkjttpj.fsf@fess.ebiederm.org
Link: https://lkml.kernel.org/r/m1eeej3g52.fsf@fess.ebiederm.org
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Marco Elver <elver@google.com>
---
v3:
* Reword warning message (Joe Perches).
* Simplify regex (Joe Perches).
v2:
* Use ?: because we don't need $2 (suggested by Dwaipayan Ray).
v1: https://lkml.kernel.org/r/20210506132827.3198497-1-elver@google.com
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ccb412a74725..c714543818e5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -7153,6 +7153,12 @@ sub process {
"Where possible, use lockdep_assert_held instead of assertions based on spin_is_locked\n" . $herecurr);
}
+# check for direct use of send_sig_info(), force_sig_info()
+ if ($sline =~ /\b(force_sig_info|send_sig_info)\s*\(/) {
+ WARN("USE_SIGINFO_HELPER",
+ "Prefer signal-specific helpers over use of '$1' (see: include/linux/sched/signal.h)\n" . $herecurr);
+ }
+
# check for deprecated apis
if ($line =~ /\b($deprecated_apis_search)\b\s*\(/) {
my $deprecated_api = $1;
--
2.31.1.607.g51e8a6a459-goog
reply other threads:[~2021-05-07 13:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507131658.3754171-1-elver@google.com \
--to=elver@google.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=ebiederm@xmission.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).