linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-kernel@vger.kernel.org (open list)
Cc: Ansuel Smith <ansuelsmth@gmail.com>
Subject: [RFC PATCH net-next v5 13/25] net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327
Date: Tue, 11 May 2021 04:04:48 +0200	[thread overview]
Message-ID: <20210511020500.17269-14-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20210511020500.17269-1-ansuelsmth@gmail.com>

Switch qca8327 needs special settings for the GLOBAL_FC_THRES regs.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 drivers/net/dsa/qca8k.c | 10 ++++++++++
 drivers/net/dsa/qca8k.h |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index b598930190e1..10e3e1ca7e95 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -930,6 +930,16 @@ qca8k_setup(struct dsa_switch *ds)
 		}
 	}
 
+	/* Special GLOBAL_FC_THRESH value are needed for ar8327 switch */
+	if (priv->switch_id == QCA8K_ID_QCA8327) {
+		mask = QCA8K_GLOBAL_FC_GOL_XON_THRES(288) |
+		       QCA8K_GLOBAL_FC_GOL_XOFF_THRES(496);
+		qca8k_rmw(priv, QCA8K_REG_GLOBAL_FC_THRESH,
+			  QCA8K_GLOBAL_FC_GOL_XON_THRES_S |
+			  QCA8K_GLOBAL_FC_GOL_XOFF_THRES_S,
+			  mask);
+	}
+
 	/* Setup our port MTUs to match power on defaults */
 	for (i = 0; i < QCA8K_NUM_PORTS; i++)
 		priv->port_mtu[i] = ETH_FRAME_LEN + ETH_FCS_LEN;
diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h
index 42d90836dffa..eceeacfe2c5d 100644
--- a/drivers/net/dsa/qca8k.h
+++ b/drivers/net/dsa/qca8k.h
@@ -168,6 +168,12 @@
 #define   QCA8K_PORT_LOOKUP_STATE			GENMASK(18, 16)
 #define   QCA8K_PORT_LOOKUP_LEARN			BIT(20)
 
+#define QCA8K_REG_GLOBAL_FC_THRESH			0x800
+#define   QCA8K_GLOBAL_FC_GOL_XON_THRES(x)		((x) << 16)
+#define   QCA8K_GLOBAL_FC_GOL_XON_THRES_S		GENMASK(24, 16)
+#define   QCA8K_GLOBAL_FC_GOL_XOFF_THRES(x)		((x) << 0)
+#define   QCA8K_GLOBAL_FC_GOL_XOFF_THRES_S		GENMASK(8, 0)
+
 #define QCA8K_REG_PORT_HOL_CTRL0(_i)			(0x970 + (_i) * 0x8)
 #define   QCA8K_PORT_HOL_CTRL0_EG_PRI0_BUF		GENMASK(3, 0)
 #define   QCA8K_PORT_HOL_CTRL0_EG_PRI0(x)		((x) << 0)
-- 
2.30.2


  parent reply	other threads:[~2021-05-11  2:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  2:04 [RFC PATCH net-next v5 00/25] Multiple improvement to qca8k stability Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 01/25] net: dsa: qca8k: change simple print to dev variant Ansuel Smith
2021-05-14 16:35   ` Andrew Lunn
2021-05-11  2:04 ` [RFC PATCH net-next v5 02/25] net: dsa: qca8k: use iopoll macro for qca8k_busy_wait Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 03/25] net: dsa: qca8k: improve qca8k read/write/rmw bus access Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 04/25] net: dsa: qca8k: handle qca8k_set_page errors Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 05/25] net: dsa: qca8k: handle error with qca8k_read operation Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 06/25] net: dsa: qca8k: handle error with qca8k_write operation Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 07/25] net: dsa: qca8k: handle error with qca8k_rmw operation Ansuel Smith
2021-05-14 16:43   ` Andrew Lunn
2021-05-11  2:04 ` [RFC PATCH net-next v5 08/25] net: dsa: qca8k: handle error from qca8k_busy_wait Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 09/25] net: dsa: qca8k: add support for qca8327 switch Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 10/25] devicetree: net: dsa: qca8k: Document new compatible qca8327 Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 11/25] net: dsa: qca8k: add priority tweak to qca8337 switch Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 12/25] net: dsa: qca8k: limit port5 delay to qca8337 Ansuel Smith
2021-05-14 16:45   ` Andrew Lunn
2021-05-11  2:04 ` Ansuel Smith [this message]
2021-05-11  2:04 ` [RFC PATCH net-next v5 14/25] net: dsa: qca8k: add support for switch rev Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 15/25] net: dsa: qca8k: add ethernet-ports fallback to setup_mdio_bus Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 16/25] net: dsa: qca8k: make rgmii delay configurable Ansuel Smith
2021-05-14 16:55   ` Andrew Lunn
2021-05-11  2:04 ` [RFC PATCH net-next v5 17/25] net: dsa: qca8k: clear MASTER_EN after phy read/write Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 18/25] net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex Ansuel Smith
2021-05-14 16:58   ` Andrew Lunn
2021-05-11  2:04 ` [RFC PATCH net-next v5 19/25] net: dsa: qca8k: enlarge mdio delay and timeout Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 20/25] net: dsa: qca8k: add support for internal phy and internal mdio Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 21/25] devicetree: bindings: dsa: qca8k: Document internal mdio definition Ansuel Smith
2021-05-11 16:23   ` Rob Herring
2021-05-11  2:04 ` [RFC PATCH net-next v5 22/25] net: dsa: qca8k: improve internal mdio read/write bus access Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 23/25] net: dsa: qca8k: pass switch_revision info to phy dev_flags Ansuel Smith
2021-05-11  2:04 ` [RFC PATCH net-next v5 24/25] net: phy: at803x: clean whitespace errors Ansuel Smith
2021-05-11  2:05 ` [RFC PATCH net-next v5 25/25] net: phy: add support for qca8k switch internal PHY in at803x Ansuel Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511020500.17269-14-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).