From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>,
Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH 17/17] tty: tty_port: Fix coding style issues of block comments
Date: Wed, 12 May 2021 17:26:25 +0800 [thread overview]
Message-ID: <1620811585-18582-18-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1620811585-18582-1-git-send-email-tanxiaofei@huawei.com>
Fix coding style issues of block comments, reported by checkpatch.pl.
Besides, add a period at the end of the sentenses.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/tty/tty_port.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index 4047954..36d49ac 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -468,7 +468,8 @@ int tty_port_block_til_ready(struct tty_port *port,
DEFINE_WAIT(wait);
/* if non-blocking mode is set we can pass directly to open unless
- the port has just hung up or is in another error state */
+ * the port has just hung up or is in another error state.
+ */
if (tty_io_error(tty)) {
tty_port_set_active(port, 1);
return 0;
@@ -485,8 +486,9 @@ int tty_port_block_til_ready(struct tty_port *port,
do_clocal = 1;
/* Block waiting until we can proceed. We may need to wait for the
- carrier, but we must also wait for any close that is in progress
- before the next open may complete */
+ * carrier, but we must also wait for any close that is in progress
+ * before the next open may complete.
+ */
retval = 0;
@@ -503,7 +505,8 @@ int tty_port_block_til_ready(struct tty_port *port,
prepare_to_wait(&port->open_wait, &wait, TASK_INTERRUPTIBLE);
/* Check for a hangup or uninitialised port.
- Return accordingly */
+ * Return accordingly.
+ */
if (tty_hung_up_p(filp) || !tty_port_initialized(port)) {
if (port->flags & ASYNC_HUP_NOTIFY)
retval = -EAGAIN;
@@ -530,7 +533,8 @@ int tty_port_block_til_ready(struct tty_port *port,
finish_wait(&port->open_wait, &wait);
/* Update counts. A parallel hangup will have set count to zero and
- we must not mess that up further */
+ * we must not mess that up further.
+ */
spin_lock_irqsave(&port->lock, flags);
if (!tty_hung_up_p(filp))
port->count++;
--
2.8.1
prev parent reply other threads:[~2021-05-12 9:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 9:26 [PATCH 00/17] tty: Fix some coding style issues Xiaofei Tan
2021-05-12 9:26 ` [PATCH 01/17] tty: tty_baudrate: Remove unnecessary tab and spaces in comment sentence Xiaofei Tan
2021-05-12 9:26 ` [PATCH 02/17] tty: tty_baudrate: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` [PATCH 03/17] tty: tty_buffer: Add a blank line after declarations Xiaofei Tan
2021-05-12 9:26 ` [PATCH 04/17] tty: tty_buffer: Remove the repeated word 'the' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 05/17] tty: tty_buffer: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` [PATCH 06/17] tty: tty_io: Remove spaces before tabs Xiaofei Tan
2021-05-12 9:26 ` [PATCH 07/17] tty: tty_io: Add a blank line after declarations Xiaofei Tan
2021-05-12 9:26 ` [PATCH 08/17] tty: tty_io: Fix spaces required around that ':' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 09/17] tty: tty_io: Fix trailing whitespace issues Xiaofei Tan
2021-05-12 9:26 ` [PATCH 10/17] tty: tty_io: Fix coding style issues of block comments Xiaofei Tan
2021-05-12 9:26 ` [PATCH 11/17] tty: tty_io: Remove the repeated word 'can' Xiaofei Tan
2021-05-12 9:26 ` [PATCH 12/17] tty: tty_io: Fix an issue of code indent for conditional statements Xiaofei Tan
2021-05-12 9:26 ` [PATCH 13/17] tty: tty_io: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12 9:26 ` [PATCH 14/17] tty: tty_io: Remove return in void function Xiaofei Tan
2021-05-12 9:26 ` [PATCH 15/17] tty: tty_port: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12 9:26 ` [PATCH 16/17] tty: tty_port: Add a blank line after declarations Xiaofei Tan
2021-05-12 9:26 ` Xiaofei Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620811585-18582-18-git-send-email-tanxiaofei@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).