[tip:,objtool/urgent] objtool: Fix elf_create_undef_symbol() endianness
diff mbox series

Message ID 162084721448.29796.15690350160125636721.tip-bot2@tip-bot2
State Accepted
Commit 46c7405df7de8deb97229eacebcee96d61415f3f
Headers show
  • [tip:,objtool/urgent] objtool: Fix elf_create_undef_symbol() endianness
Related show

Commit Message

tip-bot2 for Vincent Donnefort May 12, 2021, 7:20 p.m. UTC
The following commit has been merged into the objtool/urgent branch of tip:

Commit-ID:     46c7405df7de8deb97229eacebcee96d61415f3f
Gitweb:        https://git.kernel.org/tip/46c7405df7de8deb97229eacebcee96d61415f3f
Author:        Vasily Gorbik <gor@linux.ibm.com>
AuthorDate:    Wed, 12 May 2021 19:42:10 +02:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 12 May 2021 21:16:53 +02:00

objtool: Fix elf_create_undef_symbol() endianness

Currently x86 cross-compilation fails on big endian system with:

  x86_64-cross-ld: init/main.o: invalid string offset 488112128 >= 6229 for section `.strtab'

Mark new ELF data in elf_create_undef_symbol() as symbol, so that libelf
does endianness handling correctly.

Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()")
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: https://lore.kernel.org/r/patch-1.thread-6c9df9.git-d39264656387.your-ad-here.call-01620841104-ext-2554@work.hours
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index d08f5f3..743c2e9 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -762,6 +762,7 @@  struct symbol *elf_create_undef_symbol(struct elf *elf, const char *name)
 	data->d_buf = &sym->sym;
 	data->d_size = sizeof(sym->sym);
 	data->d_align = 1;
+	data->d_type = ELF_T_SYM;
 	sym->idx = symtab->len / sizeof(sym->sym);