From: Gavin Shan <gshan@redhat.com>
To: kvmarm@lists.cs.columbia.edu
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
drjones@redhat.com, pbonzini@redhat.com, maz@kernel.org
Subject: [PATCH] KVM: arm64: selftests: Request PMU feature in get-reg-list
Date: Thu, 13 May 2021 21:06:55 +0800 [thread overview]
Message-ID: <20210513130655.73154-1-gshan@redhat.com> (raw)
Since the following commit, PMU registers are hidden from user until
it's explicitly requested by feeding feature (KVM_ARM_VCPU_PMU_V3).
Otherwise, 74 missing PMU registers are missing as the following
log indicates.
11663111cd49 ("KVM: arm64: Hide PMU registers from userspace when not available")
# ./get-reg-list
Number blessed registers: 308
Number registers: 238
There are 74 missing registers.
The following lines are missing registers:
ARM64_SYS_REG(3, 0, 9, 14, 1),
ARM64_SYS_REG(3, 0, 9, 14, 2),
:
ARM64_SYS_REG(3, 3, 14, 15, 7),
This fixes the issue of wrongly reported missing PMU registers by
requesting it explicitly.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
tools/testing/selftests/kvm/aarch64/get-reg-list.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/kvm/aarch64/get-reg-list.c b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
index 486932164cf2..6c6bdc6f5dc3 100644
--- a/tools/testing/selftests/kvm/aarch64/get-reg-list.c
+++ b/tools/testing/selftests/kvm/aarch64/get-reg-list.c
@@ -314,6 +314,8 @@ static void core_reg_fixup(void)
static void prepare_vcpu_init(struct kvm_vcpu_init *init)
{
+ init->features[0] |= 1 << KVM_ARM_VCPU_PMU_V3;
+
if (reg_list_sve())
init->features[0] |= 1 << KVM_ARM_VCPU_SVE;
}
--
2.23.0
next reply other threads:[~2021-05-13 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:06 Gavin Shan [this message]
2021-05-13 11:14 ` [PATCH] KVM: arm64: selftests: Request PMU feature in get-reg-list Marc Zyngier
2021-05-13 13:20 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513130655.73154-1-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).