[24/34] net: ath: ath5k: Fix wrong function name in comments
diff mbox series

Message ID 1621076039-53986-25-git-send-email-shenyang39@huawei.com
State New, archived
Headers show
Series
  • Rid W=1 warnings in net
Related show

Commit Message

Yang Shen May 15, 2021, 10:53 a.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting prototype for at5k_hw_stop_rx_pcu(). Prototype was for ath5k_hw_stop_rx_pcu() instead

Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo May 15, 2021, 11:36 a.m. UTC | #1
Yang Shen <shenyang39@huawei.com> writes:

> Fixes the following W=1 kernel build warning(s):
>
>  drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting prototype for at5k_hw_stop_rx_pcu(). Prototype was for ath5k_hw_stop_rx_pcu() instead
>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Nick Kossifidis <mickflemm@gmail.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
>  drivers/net/wireless/ath/ath5k/pcu.c | 2 +-

Patches for drivers/net/wireless should be sent to linux-wireless, I
recommend submitting those patches separately from rest of the series.
(Patches 24, 25, 29, 30 and 34)
Kalle Valo May 15, 2021, 11:37 a.m. UTC | #2
Kalle Valo <kvalo@codeaurora.org> writes:

> Yang Shen <shenyang39@huawei.com> writes:
>
>> Fixes the following W=1 kernel build warning(s):
>>
>>  drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting
>> prototype for at5k_hw_stop_rx_pcu(). Prototype was for
>> ath5k_hw_stop_rx_pcu() instead
>>
>> Cc: Jiri Slaby <jirislaby@kernel.org>
>> Cc: Nick Kossifidis <mickflemm@gmail.com>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Kalle Valo <kvalo@codeaurora.org>
>> Signed-off-by: Yang Shen <shenyang39@huawei.com>
>> ---
>>  drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
>
> Patches for drivers/net/wireless should be sent to linux-wireless, I
> recommend submitting those patches separately from rest of the series.
> (Patches 24, 25, 29, 30 and 34)

Oh, and patch 33 should be also sent to linux-wireless.
Yang Shen May 17, 2021, 1:51 a.m. UTC | #3
On 2021/5/15 19:37, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Yang Shen <shenyang39@huawei.com> writes:
>>
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>>  drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting
>>> prototype for at5k_hw_stop_rx_pcu(). Prototype was for
>>> ath5k_hw_stop_rx_pcu() instead
>>>
>>> Cc: Jiri Slaby <jirislaby@kernel.org>
>>> Cc: Nick Kossifidis <mickflemm@gmail.com>
>>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>>> Cc: Kalle Valo <kvalo@codeaurora.org>
>>> Signed-off-by: Yang Shen <shenyang39@huawei.com>
>>> ---
>>>  drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
>>
>> Patches for drivers/net/wireless should be sent to linux-wireless, I
>> recommend submitting those patches separately from rest of the series.
>> (Patches 24, 25, 29, 30 and 34)
>
> Oh, and patch 33 should be also sent to linux-wireless.
>

Thanks! I'll fix this in the next version.

Regards,
     Yang

Patch
diff mbox series

diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index f2db7cf..3f4ce4e 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -855,7 +855,7 @@  ath5k_hw_start_rx_pcu(struct ath5k_hw *ah)
 }
 
 /**
- * at5k_hw_stop_rx_pcu() - Stop RX engine
+ * ath5k_hw_stop_rx_pcu() - Stop RX engine
  * @ah: The &struct ath5k_hw
  *
  * Stops RX engine on PCU