gpio: gpio-sta2x11: remove platform_set_drvdata() + cleanup probe
diff mbox series

Message ID 20210516062315.10832-1-aardelean@deviqon.com
State Accepted
Commit f716f1fb84a48cc80c1dc486f52ebc092d8d834b
Headers show
Series
  • gpio: gpio-sta2x11: remove platform_set_drvdata() + cleanup probe
Related show

Commit Message

Alexandru Ardelean May 16, 2021, 6:23 a.m. UTC
The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.

Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
 drivers/gpio/gpio-sta2x11.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Bartosz Golaszewski May 25, 2021, 2:34 p.m. UTC | #1
On Sun, May 16, 2021 at 8:23 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-sta2x11.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sta2x11.c b/drivers/gpio/gpio-sta2x11.c
> index a74bb97a41e2..392fcab06ab8 100644
> --- a/drivers/gpio/gpio-sta2x11.c
> +++ b/drivers/gpio/gpio-sta2x11.c
> @@ -398,15 +398,7 @@ static int gsta_probe(struct platform_device *dev)
>                 return err;
>         }
>
> -       err = devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
> -       if (err < 0) {
> -               dev_err(&dev->dev, "sta2x11 gpio: Can't register (%i)\n",
> -                       -err);
> -               return err;
> -       }
> -
> -       platform_set_drvdata(dev, chip);
> -       return 0;
> +       return devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
>  }
>
>  static struct platform_driver sta2x11_gpio_platform_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-sta2x11.c b/drivers/gpio/gpio-sta2x11.c
index a74bb97a41e2..392fcab06ab8 100644
--- a/drivers/gpio/gpio-sta2x11.c
+++ b/drivers/gpio/gpio-sta2x11.c
@@ -398,15 +398,7 @@  static int gsta_probe(struct platform_device *dev)
 		return err;
 	}
 
-	err = devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
-	if (err < 0) {
-		dev_err(&dev->dev, "sta2x11 gpio: Can't register (%i)\n",
-			-err);
-		return err;
-	}
-
-	platform_set_drvdata(dev, chip);
-	return 0;
+	return devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
 }
 
 static struct platform_driver sta2x11_gpio_platform_driver = {