gpio: gpio-wm8350: remove platform_set_drvdata() + cleanup probe
diff mbox series

Message ID 20210517113540.237495-2-aardelean@deviqon.com
State Accepted
Commit 0533260687a76c48e6655f7d9eb0bd1811bd9353
Headers show
Series
  • gpio: gpio-wm8350: remove platform_set_drvdata() + cleanup probe
Related show

Commit Message

Alexandru Ardelean May 17, 2021, 11:35 a.m. UTC
The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.

Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
 drivers/gpio/gpio-wm8350.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Bartosz Golaszewski May 25, 2021, 2:35 p.m. UTC | #1
On Mon, May 17, 2021 at 1:36 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-wm8350.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-wm8350.c b/drivers/gpio/gpio-wm8350.c
> index 460f0a4b04bd..b1b131fb9804 100644
> --- a/drivers/gpio/gpio-wm8350.c
> +++ b/drivers/gpio/gpio-wm8350.c
> @@ -105,7 +105,6 @@ static int wm8350_gpio_probe(struct platform_device *pdev)
>         struct wm8350 *wm8350 = dev_get_drvdata(pdev->dev.parent);
>         struct wm8350_platform_data *pdata = dev_get_platdata(wm8350->dev);
>         struct wm8350_gpio_data *wm8350_gpio;
> -       int ret;
>
>         wm8350_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm8350_gpio),
>                                    GFP_KERNEL);
> @@ -121,16 +120,7 @@ static int wm8350_gpio_probe(struct platform_device *pdev)
>         else
>                 wm8350_gpio->gpio_chip.base = -1;
>
> -       ret = devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip,
> -                                    wm8350_gpio);
> -       if (ret < 0) {
> -               dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, wm8350_gpio);
> -
> -       return ret;
> +       return devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip, wm8350_gpio);
>  }
>
>  static struct platform_driver wm8350_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-wm8350.c b/drivers/gpio/gpio-wm8350.c
index 460f0a4b04bd..b1b131fb9804 100644
--- a/drivers/gpio/gpio-wm8350.c
+++ b/drivers/gpio/gpio-wm8350.c
@@ -105,7 +105,6 @@  static int wm8350_gpio_probe(struct platform_device *pdev)
 	struct wm8350 *wm8350 = dev_get_drvdata(pdev->dev.parent);
 	struct wm8350_platform_data *pdata = dev_get_platdata(wm8350->dev);
 	struct wm8350_gpio_data *wm8350_gpio;
-	int ret;
 
 	wm8350_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm8350_gpio),
 				   GFP_KERNEL);
@@ -121,16 +120,7 @@  static int wm8350_gpio_probe(struct platform_device *pdev)
 	else
 		wm8350_gpio->gpio_chip.base = -1;
 
-	ret = devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip,
-				     wm8350_gpio);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
-		return ret;
-	}
-
-	platform_set_drvdata(pdev, wm8350_gpio);
-
-	return ret;
+	return devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip, wm8350_gpio);
 }
 
 static struct platform_driver wm8350_gpio_driver = {