From: George France <france@handhelds.org>
To: linux-kernel@vger.kernel.org
Cc: alan@lxorguk.ukuu.org.uk
Subject: [PATCH 2.4.2-ac20] trivial - de4x5 driver - stops the oops on Alpha XP1000's
Date: Mon, 19 Mar 2001 20:10:40 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.21.0103191955220.1702-100000@handhelds.org> (raw)
diff -urN linux-2.4.2-ac20-orig/drivers/net/de4x5.c
linux-2.4.2-ac20/drivers/net/de4x5.c
--- linux-2.4.2-ac20-orig/drivers/net/de4x5.c Mon Mar 19 17:24:04 2001
+++ linux-2.4.2-ac20/drivers/net/de4x5.c Mon Mar 19 18:32:01 2001
@@ -429,11 +429,17 @@
<mporter@eng.mcd.mot.com>
Remove double checking for DEBUG_RX in
de4x5_dbg_rx()
from report by <geert@linux-m68k.org>
-
+ 0.546 22-Feb-01 Fixes Alpha XP1000 oops. The srom_search
function
+ was causing a page fault when initializing the
+ variable 'pb', on a non de4x5 PCI device, in
this
+ case a PCI bridge (DEC chip 21152). The value
of
+ 'pb' is now only initialized if a de4x5 chip
is
+ present.
+ <france@handhelds.org>
=========================================================================
*/
-static const char *version = "de4x5.c:V0.545 1999/11/28
davies@maniac.ultranet.com\n";
+static const char *version = "de4x5.c:V0.546 2001/02/22
davies@maniac.ultranet.com\n";
#include <linux/config.h>
#include <linux/module.h>
@@ -2304,12 +2310,12 @@
/* Skip the pci_bus list entry */
if (list_entry(walk, struct pci_bus, devices) ==
dev->bus) continue;
- pb = this_dev->bus->number;
vendor = this_dev->vendor;
device = this_dev->device << 8;
if (!(is_DC21040 || is_DC21041 || is_DC21140 ||
is_DC2114x)) continue;
/* Get the chip configuration revision register */
+ pb = this_dev->bus->number;
pcibios_read_config_dword(pb, this_dev->devfn, PCI_REVISION_ID,
&cfrv);
/* Set the device number information */
reply other threads:[~2001-03-20 4:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0103191955220.1702-100000@handhelds.org \
--to=france@handhelds.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).