From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Randy Dunlap <rdunlap@infradead.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 02/11] nfc: mei_phy: drop ftrace-like debugging messages
Date: Fri, 28 May 2021 10:53:21 -0400 [thread overview]
Message-ID: <20210528145330.125055-2-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210528145330.125055-1-krzysztof.kozlowski@canonical.com>
Now that the kernel has ftrace, any debugging calls that just do "made
it to this function!" and "leaving this function!" can be removed.
Better to use standard debugging tools.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/mei_phy.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/nfc/mei_phy.c b/drivers/nfc/mei_phy.c
index 0f43bb389566..e56cea716cd2 100644
--- a/drivers/nfc/mei_phy.c
+++ b/drivers/nfc/mei_phy.c
@@ -98,8 +98,6 @@ static int mei_nfc_if_version(struct nfc_mei_phy *phy)
size_t if_version_length;
int bytes_recv, r;
- pr_info("%s\n", __func__);
-
memset(&cmd, 0, sizeof(struct mei_nfc_cmd));
cmd.hdr.cmd = MEI_NFC_CMD_MAINTENANCE;
cmd.hdr.data_size = 1;
@@ -146,8 +144,6 @@ static int mei_nfc_connect(struct nfc_mei_phy *phy)
size_t connect_length, connect_resp_length;
int bytes_recv, r;
- pr_info("%s\n", __func__);
-
connect_length = sizeof(struct mei_nfc_cmd) +
sizeof(struct mei_nfc_connect);
@@ -320,8 +316,6 @@ static int nfc_mei_phy_enable(void *phy_id)
int r;
struct nfc_mei_phy *phy = phy_id;
- pr_info("%s\n", __func__);
-
if (phy->powered == 1)
return 0;
@@ -363,8 +357,6 @@ static void nfc_mei_phy_disable(void *phy_id)
{
struct nfc_mei_phy *phy = phy_id;
- pr_info("%s\n", __func__);
-
mei_cldev_disable(phy->cldev);
phy->powered = 0;
--
2.27.0
next prev parent reply other threads:[~2021-05-28 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 14:53 [PATCH 01/11] nfc: fdp: drop ftrace-like debugging messages Krzysztof Kozlowski
2021-05-28 14:53 ` Krzysztof Kozlowski [this message]
2021-05-28 14:53 ` [PATCH 03/11] nfc: mrvl: use SPDX-License-Identifier Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 04/11] nfc: mrvl: correct minor coding style violations Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 05/11] nfc: mrvl: simplify with module_driver Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 06/11] nfc: pn533: drop ftrace-like debugging messages Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 07/11] nfc: pn533: drop unneeded braces {} in if Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 08/11] nfc: pn544: drop ftrace-like debugging messages Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 09/11] nfc: st21nfca: " Krzysztof Kozlowski
2021-05-28 14:55 ` [PATCH 10/11] nfc: st-nci: " Krzysztof Kozlowski
2021-05-28 14:56 ` [PATCH 11/11] nfc: st95hf: fix indentation to tabs Krzysztof Kozlowski
2021-05-28 22:13 ` [PATCH 01/11] nfc: fdp: drop ftrace-like debugging messages Jakub Kicinski
2021-05-31 7:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528145330.125055-2-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).