From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <ohad@wizery.com>, <bjorn.andersson@linaro.org>,
<mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <chengzhihao1@huawei.com>,
<yukuai3@huawei.com>
Subject: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()
Date: Tue, 1 Jun 2021 16:31:00 +0800 [thread overview]
Message-ID: <20210601083100.130776-1-chengzhihao1@huawei.com> (raw)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
---
drivers/remoteproc/pru_rproc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index e5778e476245..6491c731c6e2 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
mem_names[i]);
pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
if (IS_ERR(pru->mem_regions[i].va)) {
- dev_err(dev, "failed to parse and map memory resource %d %s\n",
- i, mem_names[i]);
ret = PTR_ERR(pru->mem_regions[i].va);
return ret;
}
--
2.31.1
next reply other threads:[~2021-06-01 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:31 Zhihao Cheng [this message]
2021-06-01 15:20 ` [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() Mathieu Poirier
2021-06-02 1:07 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601083100.130776-1-chengzhihao1@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).