[tip:,perf/urgent] perf/x86/intel/uncore: Fix M2M event umask for Ice Lake server
diff mbox series

Message ID 162255629271.29796.7893738465861951742.tip-bot2@tip-bot2
State Accepted
Commit 848ff3768684701a4ce73a2ec0e5d438d4e2b0da
Headers show
  • [tip:,perf/urgent] perf/x86/intel/uncore: Fix M2M event umask for Ice Lake server
Related show

Commit Message

tip-bot2 for Michal Suchanek June 1, 2021, 2:04 p.m. UTC
The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     848ff3768684701a4ce73a2ec0e5d438d4e2b0da
Gitweb:        https://git.kernel.org/tip/848ff3768684701a4ce73a2ec0e5d438d4e2b0da
Author:        Kan Liang <kan.liang@linux.intel.com>
AuthorDate:    Tue, 01 Jun 2021 06:09:03 -07:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 01 Jun 2021 16:00:05 +02:00

perf/x86/intel/uncore: Fix M2M event umask for Ice Lake server

Perf tool errors out with the latest event list for the Ice Lake server.

event syntax error: 'unc_m2m_imc_reads.to_pmm'
                           \___ value too big for format, maximum is 255

The same as the Snow Ridge server, the M2M uncore unit in the Ice Lake
server has the unit mask extension field as well.

Fixes: 2b3b76b5ec67 ("perf/x86/intel/uncore: Add Ice Lake server uncore support")
Reported-by: Jin Yao <yao.jin@linux.intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/1622552943-119174-1-git-send-email-kan.liang@linux.intel.com
 arch/x86/events/intel/uncore_snbep.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index 1587d32..3a75a2c 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -5099,9 +5099,10 @@  static struct intel_uncore_type icx_uncore_m2m = {
 	.perf_ctr	= SNR_M2M_PCI_PMON_CTR0,
 	.event_ctl	= SNR_M2M_PCI_PMON_CTL0,
 	.event_mask	= SNBEP_PMON_RAW_EVENT_MASK,
+	.event_mask_ext	= SNR_M2M_PCI_PMON_UMASK_EXT,
 	.box_ctl	= SNR_M2M_PCI_PMON_BOX_CTL,
 	.ops		= &snr_m2m_uncore_pci_ops,
-	.format_group	= &skx_uncore_format_group,
+	.format_group	= &snr_m2m_uncore_format_group,
 static struct attribute *icx_upi_uncore_formats_attr[] = {