lib: memscan() fixlet
diff mbox series

Message ID YLv4cCf0t5UPdyK+@localhost.localdomain
State Accepted
Commit 1a58be6277e4324c853babfd35890c2d5e171e8f
Headers show
Series
  • lib: memscan() fixlet
Related show

Commit Message

Alexey Dobriyan June 5, 2021, 10:19 p.m. UTC
Generic version doesn't trucate second argument to char.

Older brother memchr() does as do s390, sparc and i386 assembly
versions.

Fortunately, no code passes c >= 256.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 lib/string.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series

--- a/lib/string.c
+++ b/lib/string.c
@@ -977,7 +977,7 @@  void *memscan(void *addr, int c, size_t size)
 	unsigned char *p = addr;
 
 	while (size) {
-		if (*p == c)
+		if (*p == (unsigned char)c)
 			return (void *)p;
 		p++;
 		size--;