From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ed Tsai <ed.tsai@mediatek.com>
Subject: [for-next][PATCH 02/11] sched/tracing: Remove the redundant success in the sched tracepoint
Date: Wed, 09 Jun 2021 21:01:32 -0400 [thread overview]
Message-ID: <20210610010156.993158915@goodmis.org> (raw)
In-Reply-To: 20210610010130.069460694@goodmis.org
From: Ed Tsai <ed.tsai@mediatek.com>
'success' is left here for a long time and also it is meaningless
for the upper user. Just remove it.
[ There were some tools expecting this, and this may break them. But
hopefully they've been fixed in the mean time. Otherwise this may be
likely reverted - SDR ]
Link: https://lkml.kernel.org/r/20210422122226.9415-1-ed.tsai@mediatek.com
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Ed Tsai <ed.tsai@mediatek.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
include/trace/events/sched.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 1eca2305ca42..94640482cfe7 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -148,7 +148,6 @@ DECLARE_EVENT_CLASS(sched_wakeup_template,
__array( char, comm, TASK_COMM_LEN )
__field( pid_t, pid )
__field( int, prio )
- __field( int, success )
__field( int, target_cpu )
),
@@ -156,7 +155,6 @@ DECLARE_EVENT_CLASS(sched_wakeup_template,
memcpy(__entry->comm, p->comm, TASK_COMM_LEN);
__entry->pid = p->pid;
__entry->prio = p->prio; /* XXX SCHED_DEADLINE */
- __entry->success = 1; /* rudiment, kill when possible */
__entry->target_cpu = task_cpu(p);
),
--
2.30.2
next prev parent reply other threads:[~2021-06-10 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 1:01 [for-next][PATCH 00/11] tracing: Updates for 5.14 Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 01/11] tools/bootconfig: Simplify expression Steven Rostedt
2021-06-10 1:01 ` Steven Rostedt [this message]
2021-06-10 1:01 ` [for-next][PATCH 03/11] tracing: Remove redundant assignment to event_var Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 04/11] ring-buffer: Use fallthrough pseudo-keyword Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 05/11] trace: replace WB_REASON_FOREIGN_FLUSH with a string Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 06/11] tracing: Remove redundant initialization of variable ret Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 07/11] tracing: Fix set_named_trigger_data() kernel-doc comment Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 08/11] tracing: Add WARN_ON_ONCE when returned value is negative Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 09/11] tracing/boot: Add per-group/all events enablement Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 10/11] Documentation: tracing: Add per-group/all events enablement desciption Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign_str uses Steven Rostedt
2021-06-10 2:46 ` Joe Perches
2021-06-10 14:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610010156.993158915@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=ed.tsai@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).