From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: [for-next][PATCH 08/11] tracing: Add WARN_ON_ONCE when returned value is negative
Date: Wed, 09 Jun 2021 21:01:38 -0400 [thread overview]
Message-ID: <20210610010158.130786629@goodmis.org> (raw)
In-Reply-To: 20210610010130.069460694@goodmis.org
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
ret is assigned return value of event_hist_trigger_func, but the value
is unused. It is better to warn when returned value is negative,
rather than just ignoring it.
Link: https://lkml.kernel.org/r/20210529061423.GA103954@hyeyoo
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace_events_hist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index dacd6fe0f60c..ba03b7d84fc2 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -5232,6 +5232,7 @@ static void unregister_field_var_hists(struct hist_trigger_data *hist_data)
cmd = hist_data->field_var_hists[i]->cmd;
ret = event_hist_trigger_func(&trigger_hist_cmd, file,
"!hist", "hist", cmd);
+ WARN_ON_ONCE(ret < 0);
}
}
--
2.30.2
next prev parent reply other threads:[~2021-06-10 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 1:01 [for-next][PATCH 00/11] tracing: Updates for 5.14 Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 01/11] tools/bootconfig: Simplify expression Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 02/11] sched/tracing: Remove the redundant success in the sched tracepoint Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 03/11] tracing: Remove redundant assignment to event_var Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 04/11] ring-buffer: Use fallthrough pseudo-keyword Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 05/11] trace: replace WB_REASON_FOREIGN_FLUSH with a string Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 06/11] tracing: Remove redundant initialization of variable ret Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 07/11] tracing: Fix set_named_trigger_data() kernel-doc comment Steven Rostedt
2021-06-10 1:01 ` Steven Rostedt [this message]
2021-06-10 1:01 ` [for-next][PATCH 09/11] tracing/boot: Add per-group/all events enablement Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 10/11] Documentation: tracing: Add per-group/all events enablement desciption Steven Rostedt
2021-06-10 1:01 ` [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign_str uses Steven Rostedt
2021-06-10 2:46 ` Joe Perches
2021-06-10 14:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610010158.130786629@goodmis.org \
--to=rostedt@goodmis.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).