From: "irqchip-bot for Zhen Lei" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/imgpdc: Remove unnecessary oom message
Date: Fri, 11 Jun 2021 13:54:31 -0000 [thread overview]
Message-ID: <162341967160.19906.4370580021015643612.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210609140828.14584-1-thunder.leizhen@huawei.com>
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: e3f389ed3a421f45b46e774b543648ebcab9020a
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/e3f389ed3a421f45b46e774b543648ebcab9020a
Author: Zhen Lei <thunder.leizhen@huawei.com>
AuthorDate: Wed, 09 Jun 2021 22:08:28 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 11 Jun 2021 14:19:43 +01:00
irqchip/imgpdc: Remove unnecessary oom message
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message
Remove it can help us save a bit of memory.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210609140828.14584-1-thunder.leizhen@huawei.com
---
drivers/irqchip/irq-imgpdc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c
index 698d07f..04efa8e 100644
--- a/drivers/irqchip/irq-imgpdc.c
+++ b/drivers/irqchip/irq-imgpdc.c
@@ -316,10 +316,8 @@ static int pdc_intc_probe(struct platform_device *pdev)
/* Allocate driver data */
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "cannot allocate device data\n");
+ if (!priv)
return -ENOMEM;
- }
raw_spin_lock_init(&priv->lock);
platform_set_drvdata(pdev, priv);
@@ -356,10 +354,8 @@ static int pdc_intc_probe(struct platform_device *pdev)
/* Get peripheral IRQ numbers */
priv->perip_irqs = devm_kcalloc(&pdev->dev, 4, priv->nr_perips,
GFP_KERNEL);
- if (!priv->perip_irqs) {
- dev_err(&pdev->dev, "cannot allocate perip IRQ list\n");
+ if (!priv->perip_irqs)
return -ENOMEM;
- }
for (i = 0; i < priv->nr_perips; ++i) {
irq = platform_get_irq(pdev, 1 + i);
if (irq < 0)
prev parent reply other threads:[~2021-06-11 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:08 [PATCH 1/1] irqchip/imgpdc: remove unnecessary oom message Zhen Lei
2021-06-11 13:54 ` irqchip-bot for Zhen Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162341967160.19906.4370580021015643612.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).