From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 02/11] net: z85230: add blank line after declarations
Date: Sun, 13 Jun 2021 15:38:14 +0800 [thread overview]
Message-ID: <1623569903-47930-3-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623569903-47930-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
This patch fixes the checkpatch error about missing a blank line
after declarations.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/z85230.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index f074cb1..3036d58 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -74,6 +74,7 @@
static inline int z8530_read_port(unsigned long p)
{
u8 r=inb(Z8530_PORT_OF(p));
+
if(p&Z8530_PORT_SLEEP) /* gcc should figure this out efficiently ! */
udelay(5);
return r;
@@ -133,6 +134,7 @@ static inline u8 read_zsreg(struct z8530_channel *c, u8 reg)
static inline u8 read_zsdata(struct z8530_channel *c)
{
u8 r;
+
r=z8530_read_port(c->dataio);
return r;
}
@@ -653,6 +655,7 @@ static void z8530_tx_clear(struct z8530_channel *c)
static void z8530_status_clear(struct z8530_channel *chan)
{
u8 status=read_zsreg(chan, R0);
+
if(status&TxEOM)
write_zsctrl(chan, ERR_RES);
write_zsctrl(chan, RES_EXT_INT);
@@ -1360,6 +1363,7 @@ int z8530_channel_load(struct z8530_channel *c, u8 *rtable)
while(*rtable!=255)
{
int reg=*rtable++;
+
if(reg>0x0F)
write_zsreg(c, R15, c->regs[15]|1);
write_zsreg(c, reg&0x0F, *rtable);
@@ -1401,6 +1405,7 @@ EXPORT_SYMBOL(z8530_channel_load);
static void z8530_tx_begin(struct z8530_channel *c)
{
unsigned long flags;
+
if(c->tx_skb)
return;
@@ -1672,6 +1677,7 @@ static void z8530_rx_done(struct z8530_channel *c)
static inline int spans_boundary(struct sk_buff *skb)
{
unsigned long a=(unsigned long)skb->data;
+
a^=(a+skb->len);
if(a&0x00010000) /* If the 64K bit is different.. */
return 1;
--
2.8.1
next prev parent reply other threads:[~2021-06-13 7:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 7:38 [PATCH net-next 00/11] net: z85230: clean up some code style issues Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 01/11] net: z85230: remove redundant blank lines Guangbin Huang
2021-06-13 7:38 ` Guangbin Huang [this message]
2021-06-13 7:38 ` [PATCH net-next 03/11] net: z85230: fix the code style issue about EXPORT_SYMBOL(foo) Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 04/11] net: z85230: remove redundant initialization for statics Guangbin Huang
2021-06-13 16:22 ` Andrew Lunn
2021-06-14 10:21 ` lipeng (Y)
[not found] ` <3b15d3bd-4116-ebed-ba86-13efbe7958f4@huawei.com>
2021-06-14 12:28 ` Andrew Lunn
2021-06-14 13:03 ` lipeng (Y)
2021-06-13 7:38 ` [PATCH net-next 05/11] net: z85230: replace comparison to NULL with "!skb" Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 06/11] net: z85230: fix the comments style issue Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 07/11] net: z85230: fix the code style issue about "if..else.." Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 08/11] net: z85230: remove trailing whitespaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 09/11] net: z85230: add some required spaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 10/11] net: z85230: fix the code style issue about open brace { Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 11/11] net: z85230: remove unnecessary out of memory message Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623569903-47930-3-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).