From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <huangguangbin2@huawei.com>
Subject: [PATCH net-next 03/11] net: z85230: fix the code style issue about EXPORT_SYMBOL(foo)
Date: Sun, 13 Jun 2021 15:38:15 +0800 [thread overview]
Message-ID: <1623569903-47930-4-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1623569903-47930-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
According to the chackpatch.pl,
EXPORT_SYMBOL(foo); should immediately follow its function/variable.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/z85230.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
index 3036d58..94ed9a2 100644
--- a/drivers/net/wan/z85230.c
+++ b/drivers/net/wan/z85230.c
@@ -191,7 +191,6 @@ u8 z8530_dead_port[]=
{
255
};
-
EXPORT_SYMBOL(z8530_dead_port);
/*
@@ -221,7 +220,6 @@ u8 z8530_hdlc_kilostream[]=
9, NV|MIE|NORESET,
255
};
-
EXPORT_SYMBOL(z8530_hdlc_kilostream);
/*
@@ -248,7 +246,6 @@ u8 z8530_hdlc_kilostream_85230[]=
255
};
-
EXPORT_SYMBOL(z8530_hdlc_kilostream_85230);
/**
@@ -474,7 +471,6 @@ struct z8530_irqhandler z8530_sync = {
.tx = z8530_tx,
.status = z8530_status,
};
-
EXPORT_SYMBOL(z8530_sync);
/**
@@ -667,7 +663,6 @@ struct z8530_irqhandler z8530_nop = {
.tx = z8530_tx_clear,
.status = z8530_status_clear,
};
-
EXPORT_SYMBOL(z8530_nop);
/**
@@ -747,7 +742,6 @@ irqreturn_t z8530_interrupt(int irq, void *dev_id)
locker=0;
return IRQ_HANDLED;
}
-
EXPORT_SYMBOL(z8530_interrupt);
static const u8 reg_init[16]=
@@ -792,7 +786,6 @@ int z8530_sync_open(struct net_device *dev, struct z8530_channel *c)
spin_unlock_irqrestore(c->lock, flags);
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_open);
/**
@@ -821,7 +814,6 @@ int z8530_sync_close(struct net_device *dev, struct z8530_channel *c)
spin_unlock_irqrestore(c->lock, flags);
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_close);
/**
@@ -945,7 +937,6 @@ int z8530_sync_dma_open(struct net_device *dev, struct z8530_channel *c)
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_dma_open);
/**
@@ -1015,7 +1006,6 @@ int z8530_sync_dma_close(struct net_device *dev, struct z8530_channel *c)
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_dma_close);
/**
@@ -1116,7 +1106,6 @@ int z8530_sync_txdma_open(struct net_device *dev, struct z8530_channel *c)
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_txdma_open);
/**
@@ -1176,7 +1165,6 @@ int z8530_sync_txdma_close(struct net_device *dev, struct z8530_channel *c)
spin_unlock_irqrestore(c->lock, cflags);
return 0;
}
-
EXPORT_SYMBOL(z8530_sync_txdma_close);
/*
@@ -1210,7 +1198,6 @@ void z8530_describe(struct z8530_dev *dev, char *mapping, unsigned long io)
Z8530_PORT_OF(io),
dev->irq);
}
-
EXPORT_SYMBOL(z8530_describe);
/*
@@ -1312,7 +1299,6 @@ int z8530_init(struct z8530_dev *dev)
return ret;
}
-
EXPORT_SYMBOL(z8530_init);
/**
@@ -1340,7 +1326,6 @@ int z8530_shutdown(struct z8530_dev *dev)
spin_unlock_irqrestore(&dev->lock, flags);
return 0;
}
-
EXPORT_SYMBOL(z8530_shutdown);
/**
@@ -1385,7 +1370,6 @@ int z8530_channel_load(struct z8530_channel *c, u8 *rtable)
spin_unlock_irqrestore(c->lock, flags);
return 0;
}
-
EXPORT_SYMBOL(z8530_channel_load);
/**
@@ -1526,7 +1510,6 @@ void z8530_null_rx(struct z8530_channel *c, struct sk_buff *skb)
{
dev_kfree_skb_any(skb);
}
-
EXPORT_SYMBOL(z8530_null_rx);
/**
@@ -1738,7 +1721,6 @@ netdev_tx_t z8530_queue_xmit(struct z8530_channel *c, struct sk_buff *skb)
return NETDEV_TX_OK;
}
-
EXPORT_SYMBOL(z8530_queue_xmit);
/*
--
2.8.1
next prev parent reply other threads:[~2021-06-13 7:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 7:38 [PATCH net-next 00/11] net: z85230: clean up some code style issues Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 01/11] net: z85230: remove redundant blank lines Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 02/11] net: z85230: add blank line after declarations Guangbin Huang
2021-06-13 7:38 ` Guangbin Huang [this message]
2021-06-13 7:38 ` [PATCH net-next 04/11] net: z85230: remove redundant initialization for statics Guangbin Huang
2021-06-13 16:22 ` Andrew Lunn
2021-06-14 10:21 ` lipeng (Y)
[not found] ` <3b15d3bd-4116-ebed-ba86-13efbe7958f4@huawei.com>
2021-06-14 12:28 ` Andrew Lunn
2021-06-14 13:03 ` lipeng (Y)
2021-06-13 7:38 ` [PATCH net-next 05/11] net: z85230: replace comparison to NULL with "!skb" Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 06/11] net: z85230: fix the comments style issue Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 07/11] net: z85230: fix the code style issue about "if..else.." Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 08/11] net: z85230: remove trailing whitespaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 09/11] net: z85230: add some required spaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 10/11] net: z85230: fix the code style issue about open brace { Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 11/11] net: z85230: remove unnecessary out of memory message Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623569903-47930-4-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).