From: Colin King <colin.king@canonical.com>
To: Evgeniy Dushistov <dushistov@mail.ru>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ufs: remove redundant assignment to pointer p
Date: Sun, 13 Jun 2021 14:41:37 +0100 [thread overview]
Message-ID: <20210613134137.74131-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
The pointer p is being initialized with a value that is never
read before the function returns. The assignment is redundant
and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ufs/dir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c
index b721d0bda5e5..23cb6c8787f3 100644
--- a/fs/ufs/dir.c
+++ b/fs/ufs/dir.c
@@ -176,7 +176,6 @@ static bool ufs_check_page(struct page *page)
rec_len, ufs_get_de_namlen(sb, p));
goto fail;
Eend:
- p = (struct ufs_dir_entry *)(kaddr + offs);
ufs_error(sb, __func__,
"entry in directory #%lu spans the page boundary"
"offset=%lu",
--
2.31.1
next reply other threads:[~2021-06-13 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 13:41 Colin King [this message]
2022-10-10 20:47 [PATCH] ufs: Remove redundant assignment to pointer p Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210613134137.74131-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=dushistov@mail.ru \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).