From: Punit Agrawal <punitagrawal@gmail.com>
To: pmladek@suse.com, senozhatsky@chromium.org
Cc: Punit Agrawal <punitagrawal@gmail.com>,
rostedt@goodmis.org, john.ogness@linutronix.de,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org
Subject: [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition
Date: Tue, 15 Jun 2021 08:56:35 +0900 [thread overview]
Message-ID: <20210614235635.887365-1-punitagrawal@gmail.com> (raw)
Commit 28e1745b9fa2 ("printk: rename vprintk_func to vprintk") while
improving readability by removing vprintk indirection, inadvertently
placed the EXPORT_SYMBOL() for the newly renamed function at the end
of the file.
For reader sanity, and as is convention move the EXPORT_SYMBOL()
declaration just after the end of the function.
Fixes: 28e1745b9fa2 ("printk: rename vprintk_func to vprintk")
Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
--
Hi,
The out-of-place EXPORT_SYMBOL() caused an unexpected conflict while
attempting to rebase the RT patches onto newer kernels.
Generally I avoid sending trivial changes on their own but this one is
a little hard to overlook. Also it felt like an obvious oversight in
the original patch.
Please consider merging.
Thanks,
Punit
---
kernel/printk/printk_safe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c
index 7a1414622051..94232186fccb 100644
--- a/kernel/printk/printk_safe.c
+++ b/kernel/printk/printk_safe.c
@@ -391,6 +391,7 @@ asmlinkage int vprintk(const char *fmt, va_list args)
/* No obstacles. */
return vprintk_default(fmt, args);
}
+EXPORT_SYMBOL(vprintk);
void __init printk_safe_init(void)
{
@@ -411,4 +412,3 @@ void __init printk_safe_init(void)
/* Flush pending messages that did not have scheduled IRQ works. */
printk_safe_flush();
}
-EXPORT_SYMBOL(vprintk);
--
2.30.2
next reply other threads:[~2021-06-14 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 23:56 Punit Agrawal [this message]
2021-06-15 6:50 ` [PATCH] printk: Move EXPORT_SYMBOL() closer to vprintk definition Rasmus Villemoes
2021-06-15 13:36 ` Punit Agrawal
2021-06-16 6:56 ` Petr Mladek
2021-06-16 7:21 ` Petr Mladek
2021-06-16 7:51 ` John Ogness
2021-06-16 9:15 ` Petr Mladek
2021-06-16 13:52 ` Punit Agrawal
2021-06-16 1:30 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614235635.887365-1-punitagrawal@gmail.com \
--to=punitagrawal@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).