From: Zhen Lei <thunder.leizhen@huawei.com>
To: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 1/1] hpfs: remove unnecessary oom message
Date: Thu, 17 Jun 2021 16:52:03 +0800 [thread overview]
Message-ID: <20210617085203.1332-1-thunder.leizhen@huawei.com> (raw)
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message
Remove it can help us save a bit of memory.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
fs/hpfs/dnode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c
index 4ada525c5c43..40edbd6c2b7e 100644
--- a/fs/hpfs/dnode.c
+++ b/fs/hpfs/dnode.c
@@ -34,10 +34,8 @@ int hpfs_add_pos(struct inode *inode, loff_t *pos)
return 0;
if (!(i&0x0f)) {
ppos = kmalloc_array(i + 0x11, sizeof(loff_t *), GFP_NOFS);
- if (!ppos) {
- pr_err("out of memory for position list\n");
+ if (!ppos)
return -ENOMEM;
- }
if (hpfs_inode->i_rddir_off) {
memcpy(ppos, hpfs_inode->i_rddir_off, i * sizeof(loff_t));
kfree(hpfs_inode->i_rddir_off);
--
2.25.1
reply other threads:[~2021-06-17 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617085203.1332-1-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).