[1/1] quota: remove unnecessary oom message
diff mbox series

Message ID 20210617091627.1653-1-thunder.leizhen@huawei.com
State New, archived
Headers show
Series
  • [1/1] quota: remove unnecessary oom message
Related show

Commit Message

Zhen Lei June 17, 2021, 9:16 a.m. UTC
Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 fs/quota/quota_tree.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Jan Kara June 17, 2021, 3:01 p.m. UTC | #1
On Thu 17-06-21 17:16:27, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
> 
> Remove it can help us save a bit of memory.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

I agree the message is pointless. But when doing this, I guess we can just
get rid of getdqbuf() altogether and instead call kmalloc() directly in all
the places.

								Honza

> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
> index c5562c871c8b..b097d02bad94 100644
> --- a/fs/quota/quota_tree.c
> +++ b/fs/quota/quota_tree.c
> @@ -49,11 +49,7 @@ static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info)
>  
>  static char *getdqbuf(size_t size)
>  {
> -	char *buf = kmalloc(size, GFP_NOFS);
> -	if (!buf)
> -		printk(KERN_WARNING
> -		       "VFS: Not enough memory for quota buffers.\n");
> -	return buf;
> +	return kmalloc(size, GFP_NOFS);
>  }
>  
>  static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf)
> -- 
> 2.25.1
> 
>
Zhen Lei June 18, 2021, 1:20 a.m. UTC | #2
On 2021/6/17 23:01, Jan Kara wrote:
> On Thu 17-06-21 17:16:27, Zhen Lei wrote:
>> Fixes scripts/checkpatch.pl warning:
>> WARNING: Possible unnecessary 'out of memory' message
>>
>> Remove it can help us save a bit of memory.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> 
> I agree the message is pointless. But when doing this, I guess we can just
> get rid of getdqbuf() altogether and instead call kmalloc() directly in all
> the places.

OK, I will get rid of it in v2.

> 
> 								Honza
> 
>> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
>> index c5562c871c8b..b097d02bad94 100644
>> --- a/fs/quota/quota_tree.c
>> +++ b/fs/quota/quota_tree.c
>> @@ -49,11 +49,7 @@ static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info)
>>  
>>  static char *getdqbuf(size_t size)
>>  {
>> -	char *buf = kmalloc(size, GFP_NOFS);
>> -	if (!buf)
>> -		printk(KERN_WARNING
>> -		       "VFS: Not enough memory for quota buffers.\n");
>> -	return buf;
>> +	return kmalloc(size, GFP_NOFS);
>>  }
>>  
>>  static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf)
>> -- 
>> 2.25.1
>>
>>

Patch
diff mbox series

diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
index c5562c871c8b..b097d02bad94 100644
--- a/fs/quota/quota_tree.c
+++ b/fs/quota/quota_tree.c
@@ -49,11 +49,7 @@  static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info)
 
 static char *getdqbuf(size_t size)
 {
-	char *buf = kmalloc(size, GFP_NOFS);
-	if (!buf)
-		printk(KERN_WARNING
-		       "VFS: Not enough memory for quota buffers.\n");
-	return buf;
+	return kmalloc(size, GFP_NOFS);
 }
 
 static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf)