From: Vincent Donnefort <vincent.donnefort@arm.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com
Cc: vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
valentin.schneider@arm.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org,
Vincent Donnefort <vincent.donnefort@arm.com>
Subject: [PATCH 1/2] sched/rt: Fix RT utilization tracking during policy change
Date: Fri, 18 Jun 2021 14:32:18 +0100 [thread overview]
Message-ID: <1624023139-66147-1-git-send-email-vincent.donnefort@arm.com> (raw)
RT keeps track of the utilization on a per-rq basis with the structure
avg_rt. This utilization is updated during task_tick_rt(),
put_prev_task_rt() and set_next_task_rt(). However, when the current
running task changes its policy, set_next_task_rt() which would usually
take care of updating the utilization when the rq starts running RT tasks,
will not see a such change, leaving the avg_rt structure outdated. When
that very same task will be dequeued later, put_prev_task_rt() will then
update the utilization, based on a wrong last_update_time, leading a huge
spike in the RT utilization signal.
The signal would eventually recover from this issue after few ms. Even if
no RT tasks are run, avg_rt is also updated in __update_blocked_others().
But as the CPU capacity depends partly on the avg_rt, this issue has
nonetheless a significant impact on the scheduler.
Fix this issue by ensuring a load update when a running task changes
its policy to RT.
Fixes: 371bf427 ("sched/rt: Add rt_rq utilization tracking")
Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index a525447..5ac0f31 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2341,10 +2341,8 @@ void __init init_sched_rt_class(void)
static void switched_to_rt(struct rq *rq, struct task_struct *p)
{
/*
- * If we are already running, then there's nothing
- * that needs to be done. But if we are not running
- * we may need to preempt the current running task.
- * If that current running task is also an RT task
+ * If we are not running we may need to preempt the current
+ * running task. If that current running task is also an RT task
* then see if we can move to another run queue.
*/
if (task_on_rq_queued(p) && rq->curr != p) {
@@ -2355,6 +2353,13 @@ static void switched_to_rt(struct rq *rq, struct task_struct *p)
if (p->prio < rq->curr->prio && cpu_online(cpu_of(rq)))
resched_curr(rq);
}
+
+ /*
+ * If we are running, update the avg_rt tracking, as the running time
+ * will now on be accounted into the latter.
+ */
+ if (task_current(rq, p))
+ update_rt_rq_load_avg(rq_clock_pelt(rq), rq, 0);
}
/*
--
2.7.4
next reply other threads:[~2021-06-18 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 13:32 Vincent Donnefort [this message]
2021-06-18 13:32 ` [PATCH 2/2] sched/rt: Fix Deadline utilization tracking during policy change Vincent Donnefort
2021-06-21 8:40 ` Vincent Guittot
2021-06-21 8:38 ` [PATCH 1/2] sched/rt: Fix RT " Vincent Guittot
2021-06-21 9:03 ` Vincent Donnefort
2021-06-21 9:17 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624023139-66147-1-git-send-email-vincent.donnefort@arm.com \
--to=vincent.donnefort@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).