From: Dmitry Osipenko <digetx@gmail.com>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH v2 3/4] hwmon: (lm90) Unmask hardware interrupt
Date: Sat, 19 Jun 2021 00:12:01 +0300 [thread overview]
Message-ID: <20210618211202.2938-4-digetx@gmail.com> (raw)
In-Reply-To: <20210618211202.2938-1-digetx@gmail.com>
The ALERT interrupt is enabled by default after power-on, but it could
be masked by bootloader. For example this is the case on Acer A500 tablet
device. Unmask the hardware interrupt if interrupt is provided.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/hwmon/lm90.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index e7b678a40b39..658b486d2f5e 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -1704,6 +1704,13 @@ static int lm90_init_client(struct i2c_client *client, struct lm90_data *data)
if (data->kind == max6696)
config &= ~0x08;
+ /*
+ * Interrupt is enabled by default on reset, but it may be disabled
+ * by bootloader, unmask it.
+ */
+ if (client->irq)
+ config &= ~0x80;
+
config &= 0xBF; /* run */
lm90_update_confreg(data, config);
--
2.30.2
next prev parent reply other threads:[~2021-06-18 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 21:11 [PATCH v2 0/4] HWMON LM90 interrupt fixes and improvements Dmitry Osipenko
2021-06-18 21:11 ` [PATCH v2 1/4] hwmon: (lm90) Don't override interrupt trigger type Dmitry Osipenko
2021-06-18 21:12 ` [PATCH v2 2/4] hwmon: (lm90) Use hwmon_notify_event() Dmitry Osipenko
2021-06-18 21:12 ` Dmitry Osipenko [this message]
2021-06-18 21:12 ` [PATCH v2 4/4] hwmon: (lm90) Disable interrupt on suspend Dmitry Osipenko
2021-06-18 21:34 ` [PATCH v2 0/4] HWMON LM90 interrupt fixes and improvements Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618211202.2938-4-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).