From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<virtualization@lists.linux-foundation.org>
Cc: <kraxel@redhat.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<tzimmermann@suse.de>
Subject: [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()
Date: Thu, 15 Jul 2021 10:05:51 +0800 [thread overview]
Message-ID: <20210715020551.1030812-1-yangyingliang@huawei.com> (raw)
Replace pci_enable_device() with pcim_enable_device(),
pci_disable_device() will be called in release automatically.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
use pcim_enable_device()
---
drivers/gpu/drm/tiny/bochs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index a2cfecfa8556..73415fa9ae0f 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -648,7 +648,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent
if (IS_ERR(dev))
return PTR_ERR(dev);
- ret = pci_enable_device(pdev);
+ ret = pcim_enable_device(pdev);
if (ret)
goto err_free_dev;
--
2.25.1
next reply other threads:[~2021-07-15 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 2:05 Yang Yingliang [this message]
2021-07-15 9:30 ` [PATCH -next v2] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe() Thomas Zimmermann
2021-07-15 11:03 ` Yang Yingliang
2021-07-15 11:45 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715020551.1030812-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).