From: Punit Agrawal <punitagrawal@gmail.com>
To: mhiramat@kernel.org, naveen.n.rao@linux.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net
Cc: Punit Agrawal <punitagrawal@gmail.com>,
linux-kernel@vger.kernel.org, guoren@kernel.org,
linux-csky@vger.kernel.org
Subject: [PATCH v2 4/5] csky: ftrace: Drop duplicate implementation of arch_check_ftrace_location()
Date: Tue, 27 Jul 2021 22:34:25 +0900 [thread overview]
Message-ID: <20210727133426.2919710-5-punitagrawal@gmail.com> (raw)
In-Reply-To: <20210727133426.2919710-1-punitagrawal@gmail.com>
The csky specific arch_check_ftrace_location() shadows a weak
implementation of the function in core code that offers the same
functionality but with additional error checking.
Drop the architecture specific function as a step towards further
cleanup in core code.
Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
Acked-by: Guo Ren <guoren@kernel.org>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
---
arch/csky/kernel/probes/ftrace.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/csky/kernel/probes/ftrace.c b/arch/csky/kernel/probes/ftrace.c
index ef2bb9bd9605..b388228abbf2 100644
--- a/arch/csky/kernel/probes/ftrace.c
+++ b/arch/csky/kernel/probes/ftrace.c
@@ -2,13 +2,6 @@
#include <linux/kprobes.h>
-int arch_check_ftrace_location(struct kprobe *p)
-{
- if (ftrace_location((unsigned long)p->addr))
- p->flags |= KPROBE_FLAG_FTRACE;
- return 0;
-}
-
/* Ftrace callback handler for kprobes -- called under preepmt disabled */
void kprobe_ftrace_handler(unsigned long ip, unsigned long parent_ip,
struct ftrace_ops *ops, struct ftrace_regs *fregs)
--
2.30.2
next prev parent reply other threads:[~2021-07-27 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 13:34 [PATCH v2 0/5] kprobes: Bugfix and improvements Punit Agrawal
2021-07-27 13:34 ` [PATCH v2 1/5] kprobes: Do not use local variable when creating debugfs file Punit Agrawal
2021-07-27 13:34 ` [PATCH v2 2/5] kprobes: Use helper to parse boolean input from userspace Punit Agrawal
2021-07-27 13:34 ` [PATCH v2 3/5] kprobe: Simplify prepare_kprobe() by dropping redundant version Punit Agrawal
2021-07-27 13:34 ` Punit Agrawal [this message]
2021-07-28 0:50 ` [PATCH v2 4/5] csky: ftrace: Drop duplicate implementation of arch_check_ftrace_location() Guo Ren
2021-07-27 13:34 ` [PATCH v2 5/5] kprobes: Make arch_check_ftrace_location static Punit Agrawal
2021-07-27 23:39 ` [PATCH v2 0/5] kprobes: Bugfix and improvements Masami Hiramatsu
2021-08-17 12:07 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727133426.2919710-5-punitagrawal@gmail.com \
--to=punitagrawal@gmail.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).