From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: benh@kernel.crashing.org, boqun.feng@gmail.com, bp@alien8.de,
catalin.marinas@arm.com, dvyukov@google.com, elver@google.com,
ink@jurassic.park.msu.ru, jonas@southpole.se,
juri.lelli@redhat.com, linux@armlinux.org.uk, luto@kernel.org,
mark.rutland@arm.com, mattst88@gmail.com, mingo@redhat.com,
monstr@monstr.eu, mpe@ellerman.id.au, paulmck@kernel.org,
paulus@samba.org, peterz@infradead.org, rth@twiddle.net,
shorne@gmail.com, stefan.kristiansson@saunalahti.fi,
tglx@linutronix.de, vincent.guittot@linaro.org, will@kernel.org
Subject: [PATCH v4 07/10] microblaze: snapshot thread flags
Date: Tue, 3 Aug 2021 10:54:25 +0100 [thread overview]
Message-ID: <20210803095428.17009-8-mark.rutland@arm.com> (raw)
In-Reply-To: <20210803095428.17009-1-mark.rutland@arm.com>
Some thread flags can be set remotely, and so even when IRQs are
disabled, the flags can change under our feet. Generally this is
unlikely to cause a problem in practice, but it is somewhat unsound, and
KCSAN will legitimately warn that there is a data race.
To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.
Convert them all to the new flag accessor helpers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Michal Simek <monstr@monstr.eu>
---
arch/microblaze/kernel/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c
index fc61eb0eb8dd..23e8a9336a29 100644
--- a/arch/microblaze/kernel/signal.c
+++ b/arch/microblaze/kernel/signal.c
@@ -283,7 +283,7 @@ static void do_signal(struct pt_regs *regs, int in_syscall)
#ifdef DEBUG_SIG
pr_info("do signal: %p %d\n", regs, in_syscall);
pr_info("do signal2: %lx %lx %ld [%lx]\n", regs->pc, regs->r1,
- regs->r12, current_thread_info()->flags);
+ regs->r12, read_thread_flags());
#endif
if (get_signal(&ksig)) {
--
2.11.0
next prev parent reply other threads:[~2021-08-03 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 9:54 [PATCH v4 00/10] thread_info: use helpers to snapshot thread flags Mark Rutland
2021-08-03 9:54 ` [PATCH v4 01/10] thread_info: add " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 02/10] entry: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 03/10] sched: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 04/10] alpha: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 05/10] arm: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 06/10] arm64: " Mark Rutland
2021-08-03 9:54 ` Mark Rutland [this message]
2021-08-25 9:03 ` [PATCH v4 07/10] microblaze: " Michal Simek
2021-08-03 9:54 ` [PATCH v4 08/10] openrisc: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 09/10] powerpc: " Mark Rutland
2021-08-03 9:54 ` [PATCH v4 10/10] x86: " Mark Rutland
2021-08-03 16:01 ` [PATCH v4 00/10] thread_info: use helpers to " Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803095428.17009-8-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jonas@southpole.se \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).