From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] checkpatch: prefer = {} initializations to = {0}
Date: Thu, 5 Aug 2021 13:43:53 +0300 [thread overview]
Message-ID: <20210805104353.GD26417@kili> (raw)
The "= {};" style empty struct initializer is preferred over = {0}.
It avoids the situation where the first struct member is a pointer and
that generates a Sparse warning about assigning using zero instead of
NULL. Also it's just nicer to look at.
Some people complain that {} is less portable but the kernel has
different portability requirements from userspace so this is not a
issue that we care about.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 461d4221e4a4..32c8a0ca6fd0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4029,6 +4029,12 @@ sub process {
"Using $1 is unnecessary\n" . $herecurr);
}
+# prefer = {}; to = {0};
+ if ($line =~ /= \{ *0 *\}/) {
+ WARN("ZERO_INITIALIZER",
+ "= {} is preferred over = {0}\n" . $herecurr);
+ }
+
# Check for potential 'bare' types
my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
$realline_next);
--
2.30.2
next reply other threads:[~2021-08-05 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:43 Dan Carpenter [this message]
2021-08-05 12:27 ` [PATCH] checkpatch: prefer = {} initializations to = {0} Joe Perches
2021-08-05 18:04 ` Joe Perches
2021-08-05 18:17 ` Julia Lawall
2021-08-05 18:28 ` Joe Perches
2021-08-05 18:44 ` Julia Lawall
[not found] ` <20210814135922.gIT6AWiUertQCb4-mO0DlLP6vG6pje2EMBqDKlqmBVM@z>
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 14:05 ` Marion & Christophe JAILLET
2021-08-14 14:38 ` Leon Romanovsky
2021-08-14 14:57 ` Al Viro
2021-08-14 15:52 ` Leon Romanovsky
2021-08-14 16:45 ` Al Viro
2021-08-14 14:44 ` Russell King (Oracle)
2021-08-14 14:52 ` Al Viro
2021-08-14 20:20 ` Christophe JAILLET
2021-08-16 6:55 ` Dan Carpenter
2021-08-16 7:23 ` Russell King (Oracle)
2021-08-16 19:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805104353.GD26417@kili \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).