From: "Randy.Dunlap" <rddunlap@osdl.org>
To: linux-kernel@vger.kernel.org, linux-sh@m17n.org
Cc: gniibe@m17n.org, kkojima@rr.iij4u.or.jp
Subject: [PATCH] reduce stack usage in arch/sh/kernel/pci-sh7751
Date: Thu, 20 Mar 2003 12:08:33 -0800 [thread overview]
Message-ID: <20030320120833.2ddbfcc1.rddunlap@osdl.org> (raw)
Hi,
This has already been done for arch/i386 and arch/x86_64 (same function
as is patched here). Please apply to 2.5.65.
Thanks,
--
~Randy
patch_name: sh-pci-dev-stack.patch
patch_version: 2003-03-20.11:47:35
author: Randy.Dunlap <rddunlap@osdl.org>
description: reduce stack usage in
arch/sh/kernel/pci-sh7751::pcibios_fixup_peer_bridges()
product: Linux
product_versions: 2.5.65
changelog: change pci_dev and pci_bus data to pointers & kmalloc() them;
same patch as already applied to i386 and x86_64;
maintainer: Niibe Yutaka: gniibe@m17n.org,
Kazumoto Kojima: kkojima@rr.iij4u.or.jp
(list: linux-sh@m17n.org)
diffstat: =
arch/sh/kernel/pci-sh7751.c | 27 +++++++++++++++++++--------
1 files changed, 19 insertions(+), 8 deletions(-)
diff -Naur ./arch/sh/kernel/pci-sh7751.c%SHSTK ./arch/sh/kernel/pci-sh7751.c
--- ./arch/sh/kernel/pci-sh7751.c%SHSTK Mon Mar 17 13:44:19 2003
+++ ./arch/sh/kernel/pci-sh7751.c Thu Mar 20 11:46:08 2003
@@ -199,28 +199,39 @@
static void __init pcibios_fixup_peer_bridges(void)
{
int n;
- struct pci_bus bus;
- struct pci_dev dev;
+ struct pci_bus *bus;
+ struct pci_dev *dev;
u16 l;
if (pcibios_last_bus <= 0 || pcibios_last_bus >= 0xff)
return;
PCIDBG(2,"PCI: Peer bridge fixup\n");
+
+ bus = kmalloc(sizeof(*bus), GFP_ATOMIC);
+ dev = kmalloc(sizeof(*dev), GFP_ATOMIC);
+ if (!bus || !dev) {
+ printk(KERN_ERR "Out of memory in %s\n", __FUNCTION__);
+ goto exit;
+ }
+
for (n=0; n <= pcibios_last_bus; n++) {
if (pci_bus_exists(&pci_root_buses, n))
continue;
- bus.number = n;
- bus.ops = pci_root_ops;
- dev.bus = &bus;
- for(dev.devfn=0; dev.devfn<256; dev.devfn += 8)
- if (!pci_read_config_word(&dev, PCI_VENDOR_ID, &l) &&
+ bus->number = n;
+ bus->ops = pci_root_ops;
+ dev->bus = bus;
+ for(dev->devfn=0; dev->devfn<256; dev->devfn += 8)
+ if (!pci_read_config_word(dev, PCI_VENDOR_ID, &l) &&
l != 0x0000 && l != 0xffff) {
- PCIDBG(3,"Found device at %02x:%02x [%04x]\n", n, dev.devfn, l);
+ PCIDBG(3,"Found device at %02x:%02x [%04x]\n", n, dev->devfn, l);
printk(KERN_INFO "PCI: Discovered peer bus %02x\n", n);
pci_scan_bus(n, pci_root_ops, NULL);
break;
}
}
+exit:
+ kfree(dev);
+ kfree(bus);
}
next reply other threads:[~2003-03-20 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 20:08 Randy.Dunlap [this message]
2003-03-20 21:59 ` [PATCH] reduce stack usage in arch/sh/kernel/pci-sh7751 Bob Miller
2003-03-20 22:06 ` Bob Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030320120833.2ddbfcc1.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=gniibe@m17n.org \
--cc=kkojima@rr.iij4u.or.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).