From: Christoph Hellwig <hch@lst.de>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix devfs support in i386 microcode driver
Date: Sun, 6 Apr 2003 09:17:40 +0200 [thread overview]
Message-ID: <20030406091740.A6637@lst.de> (raw)
register a /dev/cpu/microcode symlink instead of a regular file
with the same name - regular file support is gone in devfs.
--- 1.17/arch/i386/kernel/microcode.c Tue Mar 11 09:16:36 2003
+++ edited/arch/i386/kernel/microcode.c Thu Mar 27 10:24:37 2003
@@ -107,7 +107,6 @@
static char *mc_applied; /* array of applied microcode blocks */
static unsigned int mc_fsize; /* file size of /dev/cpu/microcode */
-/* we share file_operations between misc and devfs mechanisms */
static struct file_operations microcode_fops = {
.owner = THIS_MODULE,
.read = microcode_read,
@@ -122,41 +121,33 @@
.fops = µcode_fops,
};
-static devfs_handle_t devfs_handle;
-
static int __init microcode_init(void)
{
int error;
error = misc_register(µcode_dev);
if (error)
- printk(KERN_WARNING
- "microcode: can't misc_register on minor=%d\n",
- MICROCODE_MINOR);
-
- devfs_handle = devfs_register(NULL, "cpu/microcode",
- DEVFS_FL_DEFAULT, 0, 0, S_IFREG | S_IRUSR | S_IWUSR,
- µcode_fops, NULL);
- if (devfs_handle == NULL && error) {
- printk(KERN_ERR "microcode: failed to devfs_register()\n");
- misc_deregister(µcode_dev);
- goto out;
- }
- error = 0;
+ goto fail;
+ error = devfs_mk_symlink("cpu/microcode", "../misc/microcode");
+ if (error)
+ goto fail_deregister;
+
printk(KERN_INFO
"IA-32 Microcode Update Driver: v%s <tigran@veritas.com>\n",
MICROCODE_VERSION);
+ return 0;
-out:
+fail_deregister:
+ misc_deregister(µcode_dev);
+fail:
return error;
}
static void __exit microcode_exit(void)
{
misc_deregister(µcode_dev);
- devfs_unregister(devfs_handle);
- if (mc_applied)
- kfree(mc_applied);
+ devfs_remove("cpu/microcode");
+ kfree(mc_applied);
printk(KERN_INFO "IA-32 Microcode Update Driver v%s unregistered\n",
MICROCODE_VERSION);
}
reply other threads:[~2003-04-06 7:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030406091740.A6637@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).