[PATCH] Re: Fwd: Re: memory usage - dentry_cacheg

From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Andreas Dilger <adilger@turbolinux.com>,
	kowalski@datrix.co.za, linux-kernel@vger.kernel.org
Subject: [PATCH] Re: Fwd: Re: memory usage - dentry_cacheg
Date: Thu, 12 Apr 2001 02:53:36 -0400	[thread overview]
Message-ID: <3AD550F0.8058FAA@mandrakesoft.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0104120110210.18135-100000@weyl.math.psu.edu>

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Alexander Viro wrote:
> We _have_ VM pressure there. However, such loads had never been used, so
> there's no wonder that system gets unbalanced under them.
> 
> I suspect that simple replacement of goto next; with continue; in the
> fs/dcache.c::prune_dcache() may make situation seriously better.

Awesome.  With the obvious patch attached, some local ramfs problems
disappeared, and my browser and e-mail program are no longer swapped out
when doing a kernel build.

Thanks :)

-- 
Jeff Garzik       | Sam: "Mind if I drive?"
Building 1024     | Max: "Not if you don't mind me clawing at the dash
MandrakeSoft      |       and shrieking like a cheerleader."

[-- Attachment #2: dcache.patch --]
[-- Type: text/plain, Size: 495 bytes --]

Index: fs/dcache.c
===================================================================
RCS file: /cvsroot/gkernel/linux_2_4/fs/dcache.c,v
retrieving revision 1.1.1.16
diff -u -r1.1.1.16 dcache.c

--- fs/dcache.c	2001/03/13 04:23:27	1.1.1.16
+++ fs/dcache.c	2001/04/12 06:51:56
@@ -340,7 +340,7 @@
 		if (dentry->d_flags & DCACHE_REFERENCED) {
 			dentry->d_flags &= ~DCACHE_REFERENCED;
 			list_add(&dentry->d_lru, &dentry_unused);
-			goto next;
+			continue;
 		}
 		dentry_stat.nr_unused--;
 
