From: Christoph Hellwig <hch@lst.de>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove unused funcion proc_mknod
Date: Mon, 5 May 2003 19:00:45 +0200 [thread overview]
Message-ID: <20030505190045.A22238@lst.de> (raw)
Not used currently and a rather bad idea in general..
--- 1.21/fs/proc/generic.c Fri Apr 25 17:46:19 2003
+++ edited/fs/proc/generic.c Mon May 5 17:26:34 2003
@@ -566,22 +566,6 @@
return ent;
}
-struct proc_dir_entry *proc_mknod(const char *name, mode_t mode,
- struct proc_dir_entry *parent, kdev_t rdev)
-{
- struct proc_dir_entry *ent;
-
- ent = proc_create(&parent,name,mode,1);
- if (ent) {
- ent->rdev = rdev;
- if (proc_register(parent, ent) < 0) {
- kfree(ent);
- ent = NULL;
- }
- }
- return ent;
-}
-
struct proc_dir_entry *proc_mkdir(const char *name, struct proc_dir_entry *parent)
{
struct proc_dir_entry *ent;
===== fs/proc/root.c 1.11 vs edited =====
--- 1.11/fs/proc/root.c Sat Sep 28 17:36:29 2002
+++ edited/fs/proc/root.c Mon May 5 17:26:26 2003
@@ -151,7 +151,6 @@
EXPORT_SYMBOL(proc_sys_root);
#endif
EXPORT_SYMBOL(proc_symlink);
-EXPORT_SYMBOL(proc_mknod);
EXPORT_SYMBOL(proc_mkdir);
EXPORT_SYMBOL(create_proc_entry);
EXPORT_SYMBOL(remove_proc_entry);
===== include/linux/proc_fs.h 1.15 vs edited =====
--- 1.15/include/linux/proc_fs.h Tue Aug 13 01:20:00 2002
+++ edited/include/linux/proc_fs.h Mon May 5 17:26:44 2003
@@ -133,8 +133,6 @@
extern struct proc_dir_entry *proc_symlink(const char *,
struct proc_dir_entry *, const char *);
-extern struct proc_dir_entry *proc_mknod(const char *,mode_t,
- struct proc_dir_entry *,kdev_t);
extern struct proc_dir_entry *proc_mkdir(const char *,struct proc_dir_entry *);
static inline struct proc_dir_entry *create_proc_read_entry(const char *name,
@@ -182,8 +180,6 @@
static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
static inline struct proc_dir_entry *proc_symlink(const char *name,
struct proc_dir_entry *parent,char *dest) {return NULL;}
-static inline struct proc_dir_entry *proc_mknod(const char *name,mode_t mode,
- struct proc_dir_entry *parent,kdev_t rdev) {return NULL;}
static inline struct proc_dir_entry *proc_mkdir(const char *name,
struct proc_dir_entry *parent) {return NULL;}
next reply other threads:[~2003-05-05 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-05 17:00 Christoph Hellwig [this message]
2003-05-05 19:22 ` [PATCH] remove unused funcion proc_mknod viro
2003-05-05 19:30 ` Christoph Hellwig
2003-05-05 20:45 ` Jeff Garzik
2003-05-09 11:43 ` Jaroslav Kysela
2003-05-09 11:47 ` Christoph Hellwig
2003-05-09 11:55 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030505190045.A22238@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).