From: Olivier Galibert <galibert@pobox.com>
To: linux-acenic@SunSITE.auc.dk, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Subject: [patch] Acenic tigon 1 support fix
Date: Mon, 30 Apr 2001 17:01:39 -0400 [thread overview]
Message-ID: <20010430170138.A1085@nemesis.ncsl.nist.gov> (raw)
A typo prevents the tigon 1 firmware to be included when tigon 1
support is active. Null pointer dereference in
ace_load_firmware->ace_copy as a result.
Patch trivial and even tested (aka, the module loads without oopsing
with a tigon 1 inside).
OG.
--- linux/drivers/net/acenic_firmware.h Tue Mar 6 22:28:33 2001
+++ linux-2.4.4/drivers/net/acenic_firmware.h Mon Apr 30 16:51:25 2001
@@ -17,7 +17,7 @@
#define tigonFwSbssLen 0x38
#define tigonFwBssAddr 0x00015dd0
#define tigonFwBssLen 0x2080
-#ifndef CONFIG_ACENIC_OMIT_TIGON_I
+#ifdef CONFIG_ACENIC_OMIT_TIGON_I
#define tigonFwText 0
#define tigonFwData 0
#define tigonFwRodata 0
next reply other threads:[~2001-04-30 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-30 21:01 Olivier Galibert [this message]
2001-05-10 18:59 ` [patch] Acenic tigon 1 support fix Jes Sorensen
2001-05-10 20:11 ` Olivier Galibert
2001-05-13 13:53 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010430170138.A1085@nemesis.ncsl.nist.gov \
--to=galibert@pobox.com \
--cc=linux-acenic@SunSITE.auc.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).